Make QEMU version, arch and flags overridable via environment variables#4418
Make QEMU version, arch and flags overridable via environment variables#4418xuxiaowei-com-cn wants to merge 2 commits into
Conversation
Allow customizing QEMUVERSION and QEMUFLAGS without modifying Makefiles, so that users can use different QEMU configurations for cross-arch builds.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xuxiaowei-com-cn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @xuxiaowei-com-cn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Use ?= instead of = for ALL_ARCH so it can be overridden, consistent with ARCH and the recent QEMU variable changes (7f6c512).
|
Allow customizing QEMUVERSION and QEMUFLAGS without modifying Makefiles, so that users can use different QEMU configurations for cross-arch builds.
What type of PR is this?
/kind cleanup
#4417
What this PR does / why we need it:
Makes QEMU version, flags, and ALL_ARCH configurable via environment variables in three image build Makefiles:
QEMUVERSIONfrom=to?=so it can be overridden--reset -p yesflags into a newQEMUFLAGSvariable with?=assignmentdocker runwith$(QEMUFLAGS)ALL_ARCHfrom=to?=so target architectures can be overriddenThis allows downstream users and CI pipelines to customize QEMU behavior and target architectures without patching the Makefiles.
Files changed:
images/build/debian-base/Makefileimages/build/distroless-iptables/Makefileimages/build/setcap/MakefileWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
The changes are identical across all three files — extracting hardcoded values into conditionally-assignable variables (
?=). The default behavior is unchanged.Does this PR introduce a user-facing change?