Skip to content

Release Notes draft for k/k v1.36.0-rc.1#3003

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
singh1203:release-notes-draft-v1.36.0-rc.1
Apr 21, 2026
Merged

Release Notes draft for k/k v1.36.0-rc.1#3003
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
singh1203:release-notes-draft-v1.36.0-rc.1

Conversation

@singh1203
Copy link
Copy Markdown
Contributor

@singh1203 singh1203 commented Apr 18, 2026

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR updates the Release Notes Draft to k/k v1.36.0-rc.1

Which issue(s) this PR fixes:

Special notes for your reviewer:

This is an automated PR generated from krel The Kubernetes Release Toolbox

Checklist:

  • krel validate is successful
  • Once again, manually added the PR #137719 notes missed during beta.0 release notes

cc: @sayanchowdhury, @kernel-kun, @em-sav, @AnshumanTripathi

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/release-team Issues or PRs related to the release-team subproject needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 18, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2026
@singh1203 singh1203 force-pushed the release-notes-draft-v1.36.0-rc.1 branch from d7c52b5 to 8653b8b Compare April 18, 2026 10:56
@singh1203 singh1203 changed the title [Draft] Release Notes draft for k/k v1.36.0-rc.1 Release Notes draft for k/k v1.36.0-rc.1 Apr 18, 2026
@k8s-triage-robot
Copy link
Copy Markdown

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2026
Copy link
Copy Markdown
Contributor

@kernel-kun kernel-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Saurabh for the PR! 🚀
Just added a few fixes...
I'll try doing a more thorough review a bit later

Comment thread releases/release-1.36/release-notes/maps/pr-138244-map.yaml Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.json Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
@singh1203 singh1203 requested a review from kernel-kun April 18, 2026 18:26
Copy link
Copy Markdown
Contributor

@kernel-kun kernel-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions summary

  1. PR #138318 (DRA e2e tests) - Line 8566 in JSON & line 290 in MD:
  • Fix spelling: `air-gaped` → `air-gapped`
  • Create corresponding map file for override
  1. Duplicate Go version entries - Multiple PRs need `do_not_publish`:
  • Line 4791 in JSON: PR should be hidden in favor of #137501
  • Line 6196 in JSON: PR should be hidden in favor of #137501
  1. Map file cleanup:
  • Line 2190 in JSON: Remove extra indent
  1. Version formatting - Line 185 in MD:
  • Create map file for `v1.26.2` overrides

Everything else looks pretty good from my end. I'll add /lgtm from my side once changes are incorporated 👍🏻
Thanks for the awesome work!!

CC: @singh1203

Comment thread releases/release-1.36/release-notes/release-notes-draft.json Outdated
"network"
],
"duplicate": true,
"do_not_publish": true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set this PR to do_not_publish in favor of #137501

Copy link
Copy Markdown
Contributor Author

@singh1203 singh1203 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed! Since it was required for PR #136796
Thank you 🙇

"network"
],
"duplicate_kind": true,
"do_not_publish": true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set this PR to do_not_publish in favor of #137501

Copy link
Copy Markdown
Contributor Author

@singh1203 singh1203 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, for info, it was PR #137169 👍
I think Krel is our faulty guy.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, since these changes were manually made to the .json, krel seems to revert it back on each subsequent run

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should open an issue on it if not present.
@kernel-kun

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's because we haven't added the do_not_publish field to the map files
I haven't read through the code if adding that override to map file actually propagates downstream to the .json as well (since for pr_body, that didn't hold true in original source code)

I'll go over that issue and see if it's an easy fix to integrate to existing PR for krel rerun

Comment thread releases/release-1.36/release-notes/release-notes-draft.json Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.json Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
Comment thread releases/release-1.36/release-notes/release-notes-draft.md
Comment thread releases/release-1.36/release-notes/release-notes-draft.md Outdated
@kernel-kun
Copy link
Copy Markdown
Contributor

Reviewer Notes

PR's getting added in this rc.1

  • PR #138244: - Fixed a kubelet device manager bug where topology hint computation enumerated O(2^n) NUMA node combinations using all machine NUMA nodes. On systems with many NUMA nodes that carry no devices (e.g.
  • PR #138299: - Kubernetes is now built using Go v1.26.2. (#138299, @xmudrii) [SIG Release and Testing]
  • PR #138318: - Fixed running of DRA e2e tests in air-gaped clusters or with test images in private registries. (#138318, [@jsafrane](https://github.com/jsafr

PR's getting removed

None

@kernel-kun
Copy link
Copy Markdown
Contributor

kernel-kun commented Apr 20, 2026

Great work here @singh1203 🚀
We should be good to re-base and force-push

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2026
Copy link
Copy Markdown
Member

@sayanchowdhury sayanchowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@singh1203 singh1203 force-pushed the release-notes-draft-v1.36.0-rc.1 branch from 03b9d52 to edbcd47 Compare April 20, 2026 10:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2026
@singh1203
Copy link
Copy Markdown
Contributor Author

Great work here @singh1203 🚀 We should be good to re-base and force-push

Rebased the commits into one, which removed the lgtm label.
cc: @sayanchowdhury @kernel-kun @em-sav @AnshumanTripathi

@kernel-kun
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2026
@sayanchowdhury
Copy link
Copy Markdown
Member

cc @dipesh-rawat @rytswd Can you please review the release notes PR.

@rytswd
Copy link
Copy Markdown
Member

rytswd commented Apr 20, 2026

LGTM from my end, adding my approval and holding so that you can control when to merge this

/lgtm
/approve

@rytswd
Copy link
Copy Markdown
Member

rytswd commented Apr 20, 2026

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rytswd, sayanchowdhury, singh1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@sayanchowdhury
Copy link
Copy Markdown
Member

Thanks for the review @rytswd

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2026
@k8s-ci-robot k8s-ci-robot merged commit 81c03cc into kubernetes:master Apr 21, 2026
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants