Release Notes draft for k/k v1.36.0-rc.1#3003
Conversation
d7c52b5 to
8653b8b
Compare
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
kernel-kun
left a comment
There was a problem hiding this comment.
Thanks a lot Saurabh for the PR! 🚀
Just added a few fixes...
I'll try doing a more thorough review a bit later
There was a problem hiding this comment.
Suggestions summary
- PR #138318 (DRA e2e tests) - Line 8566 in JSON & line 290 in MD:
- Fix spelling: `air-gaped` → `air-gapped`
- Create corresponding map file for override
- Duplicate Go version entries - Multiple PRs need `do_not_publish`:
- Line 4791 in JSON: PR should be hidden in favor of #137501
- Line 6196 in JSON: PR should be hidden in favor of #137501
- Map file cleanup:
- Line 2190 in JSON: Remove extra indent
- Version formatting - Line 185 in MD:
- Create map file for `v1.26.2` overrides
Everything else looks pretty good from my end. I'll add
/lgtmfrom my side once changes are incorporated 👍🏻
Thanks for the awesome work!!
CC: @singh1203
| "network" | ||
| ], | ||
| "duplicate": true, | ||
| "do_not_publish": true, |
There was a problem hiding this comment.
We can set this PR to do_not_publish in favor of #137501
There was a problem hiding this comment.
Addressed! Since it was required for PR #136796
Thank you 🙇
| "network" | ||
| ], | ||
| "duplicate_kind": true, | ||
| "do_not_publish": true, |
There was a problem hiding this comment.
We can set this PR to do_not_publish in favor of #137501
There was a problem hiding this comment.
Added, for info, it was PR #137169 👍
I think Krel is our faulty guy.
There was a problem hiding this comment.
Yep, since these changes were manually made to the .json, krel seems to revert it back on each subsequent run
There was a problem hiding this comment.
Maybe we should open an issue on it if not present.
@kernel-kun
There was a problem hiding this comment.
I think that's because we haven't added the do_not_publish field to the map files
I haven't read through the code if adding that override to map file actually propagates downstream to the .json as well (since for pr_body, that didn't hold true in original source code)
I'll go over that issue and see if it's an easy fix to integrate to existing PR for krel rerun
Reviewer NotesPR's getting added in this
|
|
Great work here @singh1203 🚀 |
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
03b9d52 to
edbcd47
Compare
Rebased the commits into one, which removed the lgtm label. |
|
/lgtm |
|
cc @dipesh-rawat @rytswd Can you please review the release notes PR. |
|
LGTM from my end, adding my approval and holding so that you can control when to merge this /lgtm |
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rytswd, sayanchowdhury, singh1203 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the review @rytswd /hold cancel |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.36.0-rc.1
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is an automated PR generated from
krel The Kubernetes Release ToolboxChecklist:
krel validateis successfulbeta.0release notescc: @sayanchowdhury, @kernel-kun, @em-sav, @AnshumanTripathi