Skip to content

Add fallback URL for Testkube CLI download when release tag format doesn't match #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add fallback URL for Testkube CLI download when release tag format doesn't match #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab728b
Initial plan
Copilot Mar 18, 2026
0818def
Fix download URL fallback for Testkube CLI v2.4.0+ tag format change
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35011,6 +35011,7 @@ __nccwpck_require__.r(__webpack_exports__);




// From 2.4.0 we dropped the `v` prefix. Before that we should respect that.
const TAG_UPDATED_SINCE = "2.4.0";
const params = {
Expand Down Expand Up @@ -35134,13 +35135,30 @@ else {
}
const encodedVersion = encodeURIComponent(params.version);
const encodedVerSysArch = `${encodeURIComponent(params.version)}_${encodeURIComponent(system)}_${encodeURIComponent(architecture)}`;
// Before 2.4.0, release tags used a "v" prefix (e.g. v2.3.0). From 2.4.0 onward, the prefix was dropped.
// We pick the expected URL based on semver, then fall back to the alternative format on HTTP errors.
const isLegacyVersion = semver__WEBPACK_IMPORTED_MODULE_7___default().lt(encodedVersion, TAG_UPDATED_SINCE);
const artifactUrl = isLegacyVersion
const primaryArtifactUrl = isLegacyVersion
? `https://github.com/kubeshop/testkube/releases/download/v${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`
: `https://github.com/kubeshop/testkube/releases/download/${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`;
const fallbackArtifactUrl = isLegacyVersion
? `https://github.com/kubeshop/testkube/releases/download/${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`
: `https://github.com/kubeshop/testkube/releases/download/v${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`;
if (!isTestkubeInstalled) {
process.stdout.write(`Downloading the artifact from "${artifactUrl}"...\n`);
const artifactPath = await _actions_tool_cache__WEBPACK_IMPORTED_MODULE_4__.downloadTool(artifactUrl);
let artifactPath;
process.stdout.write(`Downloading the artifact from "${primaryArtifactUrl}"...\n`);
try {
artifactPath = await _actions_tool_cache__WEBPACK_IMPORTED_MODULE_4__.downloadTool(primaryArtifactUrl);
}
catch (e) {
if (e instanceof _actions_tool_cache__WEBPACK_IMPORTED_MODULE_4__.HTTPError && e.httpStatusCode === 404) {
process.stdout.write(`Primary URL failed, falling back to "${fallbackArtifactUrl}"...\n`);
artifactPath = await _actions_tool_cache__WEBPACK_IMPORTED_MODULE_4__.downloadTool(fallbackArtifactUrl);
}
else {
throw e;
}
}
if (node_fs__WEBPACK_IMPORTED_MODULE_1__.existsSync(`${binaryDirPath}/kubectl-testkube`)) {
node_fs__WEBPACK_IMPORTED_MODULE_1__.rmSync(`${binaryDirPath}/kubectl-testkube`);
}
Expand Down
24 changes: 21 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import * as fs from "node:fs";
import * as path from "node:path";
import * as os from "node:os";
import * as toolCache from "@actions/tool-cache";
import { HTTPError } from "@actions/tool-cache";
import { getInput, addPath } from "@actions/core";
import got from "got";
import which from "which";
Expand Down Expand Up @@ -161,14 +162,31 @@ if (isTestkubeInstalled) {
architecture
)}`;

// Before 2.4.0, release tags used a "v" prefix (e.g. v2.3.0). From 2.4.0 onward, the prefix was dropped.
// We pick the expected URL based on semver, then fall back to the alternative format on HTTP errors.
const isLegacyVersion = semver.lt(encodedVersion, TAG_UPDATED_SINCE);
const artifactUrl = isLegacyVersion
const primaryArtifactUrl = isLegacyVersion
? `https://github.com/kubeshop/testkube/releases/download/v${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`
: `https://github.com/kubeshop/testkube/releases/download/${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`;
const fallbackArtifactUrl = isLegacyVersion
? `https://github.com/kubeshop/testkube/releases/download/${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`
: `https://github.com/kubeshop/testkube/releases/download/v${encodedVersion}/testkube_${encodedVerSysArch}.tar.gz`;

if (!isTestkubeInstalled) {
process.stdout.write(`Downloading the artifact from "${artifactUrl}"...\n`);
const artifactPath = await toolCache.downloadTool(artifactUrl);
let artifactPath: string;
process.stdout.write(`Downloading the artifact from "${primaryArtifactUrl}"...\n`);
try {
artifactPath = await toolCache.downloadTool(primaryArtifactUrl);
} catch (e: unknown) {
if (e instanceof HTTPError && e.httpStatusCode === 404) {
process.stdout.write(
`Primary URL failed, falling back to "${fallbackArtifactUrl}"...\n`
);
artifactPath = await toolCache.downloadTool(fallbackArtifactUrl);
} else {
throw e;
}
}
if (fs.existsSync(`${binaryDirPath}/kubectl-testkube`)) {
fs.rmSync(`${binaryDirPath}/kubectl-testkube`);
}
Expand Down