vk: Dynamic per-binding IUB/UBO selection based on device limits#337
Merged
Conversation
Instead of a global bool deciding all Plain bindings use inline uniform blocks or all use UBOs, store the device's maxInlineUniformBlockSize and decide per-binding: bindings that fit use IUBs, larger ones fall back to UBOs. This fixes validation errors when binding sizes exceed the device's inline uniform block limits (e.g. light arrays > 256 bytes). Resolves #334. https://claude.ai/code/session_01W9jSvpnbXEXmoHFuUVFdUN
kvark
force-pushed
the
claude/nvidia-prime-investigation-wUmwH
branch
from
April 13, 2026 06:27
f43f3f6 to
654146b
Compare
kvark
enabled auto-merge (rebase)
April 13, 2026 06:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a global bool deciding all Plain bindings use inline uniform blocks or all use UBOs, store the device's maxInlineUniformBlockSize and decide per-binding: bindings that fit use IUBs, larger ones fall back to UBOs. This fixes validation errors when binding sizes exceed the device's inline uniform block limits (e.g. light arrays > 256 bytes).
Resolves #334.
https://claude.ai/code/session_01W9jSvpnbXEXmoHFuUVFdUN