Skip to content

vk: Use driver API version for instance creation #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvark merged 2 commits into from
Apr 17, 2026
Merged

vk: Use driver API version for instance creation #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2c212
vk: Use driver API version for instance creation
hellno Apr 15, 2026
6e2900e
vk: Cap instance API version at header version
hellno Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blade-graphics/src/vulkan/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ impl super::VulkanInstance {
let app_info = vk::ApplicationInfo::default()
.engine_name(c"blade")
.engine_version(1)
.api_version(vk::HEADER_VERSION_COMPLETE);
.api_version(driver_api_version);

@kvark kvark Apr 16, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should take minimum of ours and theirs, not just theirs

@hellno hellno Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, changed it!

let str_pointers = layers
.iter()
.chain(enabled_instance_extensions.iter())
Expand Down
Loading