Uprev Naga to pick up emit_int_div_checks#357
Merged
Conversation
Point naga at gfx-rs/wgpu trunk (rev 78b4dfd) instead of the crates.io v29 release. Adapt to the SPIR-V and MSL backend Options structs, which gained new fields: - emit_int_div_checks (guards integer div/mod against zero and overflow) - trace_ray_argument_validation (SPIR-V; validates traceRays arguments) - task_dispatch_limits, mesh_shader_primitive_indices_clamp (MSL) All set to the naga defaults to preserve existing behavior. https://claude.ai/code/session_01W9jSvpnbXEXmoHFuUVFdUN
Turn off the naga-injected runtime checks now that they default on: - emit_int_div_checks (SPIR-V + MSL): no div-by-zero / INT_MIN overflow guards - trace_ray_argument_validation (SPIR-V): no traceRays argument checks - ray_query_initialization_tracking (SPIR-V): no ray query state tracking These trade defined-on-misuse behavior for raw codegen speed; blade guarantees correct shader usage at the call sites. https://claude.ai/code/session_01W9jSvpnbXEXmoHFuUVFdUN
kvark
enabled auto-merge (squash)
June 15, 2026 00:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See gfx-rs/wgpu#9443