Closed
Conversation
added 2 commits
October 26, 2022 09:44
previous functionality did not support create/drop of views within a schema. This causes issues when a users is expecting the view to exist within the schema specified by the metadata object - but it is instead created in the default schema regardless. adding in fuctionality to support creation of views within a schema as provided by the metadata object. Defaults to None if no schema is present. adding in functionality to specify schema when dropping view as provided by metadata object modified: sqlalchemy_utils/view.py
some of the lines were longer than the linter liked modified: sqlalchemy_utils/view.py
Author
|
actually this looks like I have duplicated #621 |
rec
added a commit
to rec/sqlalchemy-utils
that referenced
this pull request
Oct 27, 2022
Owner
|
Closing as this is a duplicate of #621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality to
create_viewanddrop_viewthat allows a non-default schema to be specified. #650