Add support for batch and draft/chathistory capabilities#2746
Open
ctrlaltca wants to merge 1 commit intokvirc:masterfrom
Open
Add support for batch and draft/chathistory capabilities#2746ctrlaltca wants to merge 1 commit intokvirc:masterfrom
ctrlaltca wants to merge 1 commit intokvirc:masterfrom
Conversation
Contributor
Author
|
@DarthGandalf can you have a look at this please? |
Member
DarthGandalf
left a comment
DarthGandalf
left a comment
There was a problem hiding this comment.
- I see only batch here, not draft/chathistory
- it doesn't actually do anything with BATCH other than just not complaining about unknown message?
- if server sends too many BATCH + with random ids, it'll eventually OOM the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #2745
This PR will enable the capabilities if supported by the server (use irc.unrealircd.org for tests)
A new
OnBatchevent has been addedMessages will contain a new
@batchmessage tag when relevantNo UI/Option have been added right now, but a simple event handler for
OnMeJoincan make such a request: