Skip to content

fix(l1): use SUPPORTED_SNAP_CAPABILITIES in snap client peer selection #6154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pablodeymo wants to merge 39 commits into from
Closed

fix(l1): use SUPPORTED_SNAP_CAPABILITIES in snap client peer selection #6154

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
2c5797e
refactor(l1): unify snapsync healing modules into sync/healing/ direc…
pablodeymo Jan 21, 2026
713ea92
refactor(l1): modularize snap protocol code into dedicated directories
pablodeymo Jan 21, 2026
9f9214f
docs: add snap sync refactoring plan
pablodeymo Jan 21, 2026
2013570
refactor(l1): split sync.rs into full.rs and snap_sync.rs modules
pablodeymo Jan 21, 2026
68867ae
refactor(l1): extract snap client methods from peer_handler.rs to sna…
pablodeymo Jan 21, 2026
d91bc8b
refactor(l1): consolidate snap protocol error handling into unified S…
pablodeymo Jan 22, 2026
57ebf37
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Jan 22, 2026
f680777
fix(l1): use consistent usize type for missing_children_count
pablodeymo Jan 22, 2026
17744dc
fix(l1): fix typos in healing module comments
pablodeymo Jan 22, 2026
2836e3f
Merge main into refactor/snapsync-healing-unification
pablodeymo Jan 27, 2026
c40de29
fix(l1): fix typo in snap client error message
pablodeymo Jan 27, 2026
ffba3fe
fix(l1): prevent panic on empty accounts vector in snap client
pablodeymo Jan 27, 2026
a682d76
fix(l1): handle empty bytecode hashes in request_bytecodes
pablodeymo Jan 27, 2026
6c99453
fix(l1): prevent panics from empty vector indexing in snap client
pablodeymo Jan 27, 2026
91b926e
fix(l1): prevent zero chunk_size in request_account_range
pablodeymo Jan 27, 2026
f3983c3
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Jan 28, 2026
3c962dd
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Jan 29, 2026
1e87e25
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Jan 30, 2026
9a98f65
Merge main into refactor/snapsync-healing-unification
pablodeymo Feb 2, 2026
e424237
Replace .get(0) with .first() in snap client to fix clippy lint errors
pablodeymo Feb 2, 2026
02b1dc2
fmt
pablodeymo Feb 2, 2026
0656d2e
Remove plan_snap_sync.md (content moved to PR description)
pablodeymo Feb 2, 2026
94a35ff
Derive thiserror::Error for DumpError
pablodeymo Feb 2, 2026
8eabda7
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Feb 3, 2026
161cf78
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Feb 4, 2026
d01f055
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Feb 5, 2026
a242f55
Add per-phase timing breakdown to Slack notifications and run logs
pablodeymo Feb 5, 2026
7042b83
Update tooling/sync/docker_monitor.py
pablodeymo Feb 5, 2026
1414a3b
Propagate errors instead of panicking in request_storage_ranges and move
pablodeymo Feb 5, 2026
4a2c153
Address PR quick-fix feedback: use SUPPORTED_SNAP_CAPABILITIES for snap
pablodeymo Feb 5, 2026
eaf2a8c
Convert snap client methods from PeerHandler extension to standalone …
pablodeymo Feb 5, 2026
6f12101
Merge branch 'main' into feature/slack-phase-breakdown
pablodeymo Feb 6, 2026
6e87eb2
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Feb 6, 2026
8e06aa5
Move snap_server_tests from crates/networking/p2p/tests/ to test/test…
pablodeymo Feb 6, 2026
48c39cc
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo Feb 6, 2026
b571e36
Use SUPPORTED_SNAP_CAPABILITIES for snap client peer selection
pablodeymo Feb 6, 2026
216ee7f
Merge branch 'main' into feature/slack-phase-breakdown
pablodeymo Feb 6, 2026
9bc7a4d
Merge remote-tracking branch 'origin/refactor/snapsync-healing-unific…
pablodeymo Feb 6, 2026
b8bf73a
Merge remote-tracking branch 'origin/feature/slack-phase-breakdown' i…
pablodeymo Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/networking/p2p/peer_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::{
HashOrNumber,
},
message::Message as RLPxMessage,
p2p::{Capability, SUPPORTED_ETH_CAPABILITIES},
p2p::{Capability, SUPPORTED_ETH_CAPABILITIES, SUPPORTED_SNAP_CAPABILITIES},
snap::{
AccountRange, AccountRangeUnit, ByteCodes, GetAccountRange, GetByteCodes,
GetStorageRanges, GetTrieNodes, StorageRanges, TrieNodes,
Expand Down Expand Up @@ -737,7 +737,7 @@ impl PeerHandler {

let Some((peer_id, connection)) = self
.peer_table
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
.get_best_peer(&SUPPORTED_SNAP_CAPABILITIES)
.await
.inspect_err(|err| warn!(%err, "Error requesting a peer for account range"))
.unwrap_or(None)
Expand Down Expand Up @@ -1024,7 +1024,7 @@ impl PeerHandler {

let Some((peer_id, mut connection)) = self
.peer_table
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
.get_best_peer(&SUPPORTED_SNAP_CAPABILITIES)
.await
.inspect_err(|err| warn!(%err, "Error requesting a peer for bytecodes"))
.unwrap_or(None)
Expand Down Expand Up @@ -1550,7 +1550,7 @@ impl PeerHandler {

let Some((peer_id, connection)) = self
.peer_table
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
.get_best_peer(&SUPPORTED_SNAP_CAPABILITIES)
.await
.inspect_err(|err| warn!(%err, "Error requesting a peer for storage ranges"))
.unwrap_or(None)
Expand Down
Loading