-
Notifications
You must be signed in to change notification settings - Fork 194
fix(l1): use SUPPORTED_SNAP_CAPABILITIES in snap client peer selection #6154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2c5797e
refactor(l1): unify snapsync healing modules into sync/healing/ direc…
pablodeymo 713ea92
refactor(l1): modularize snap protocol code into dedicated directories
pablodeymo 9f9214f
docs: add snap sync refactoring plan
pablodeymo 2013570
refactor(l1): split sync.rs into full.rs and snap_sync.rs modules
pablodeymo 68867ae
refactor(l1): extract snap client methods from peer_handler.rs to sna…
pablodeymo d91bc8b
refactor(l1): consolidate snap protocol error handling into unified S…
pablodeymo 57ebf37
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo f680777
fix(l1): use consistent usize type for missing_children_count
pablodeymo 17744dc
fix(l1): fix typos in healing module comments
pablodeymo 2836e3f
Merge main into refactor/snapsync-healing-unification
pablodeymo c40de29
fix(l1): fix typo in snap client error message
pablodeymo ffba3fe
fix(l1): prevent panic on empty accounts vector in snap client
pablodeymo a682d76
fix(l1): handle empty bytecode hashes in request_bytecodes
pablodeymo 6c99453
fix(l1): prevent panics from empty vector indexing in snap client
pablodeymo 91b926e
fix(l1): prevent zero chunk_size in request_account_range
pablodeymo f3983c3
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo 3c962dd
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo 1e87e25
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo 9a98f65
Merge main into refactor/snapsync-healing-unification
pablodeymo e424237
Replace .get(0) with .first() in snap client to fix clippy lint errors
pablodeymo 02b1dc2
fmt
pablodeymo 0656d2e
Remove plan_snap_sync.md (content moved to PR description)
pablodeymo 94a35ff
Derive thiserror::Error for DumpError
pablodeymo 8eabda7
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo 161cf78
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo d01f055
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo a242f55
Add per-phase timing breakdown to Slack notifications and run logs
pablodeymo 7042b83
Update tooling/sync/docker_monitor.py
pablodeymo 1414a3b
Propagate errors instead of panicking in request_storage_ranges and move
pablodeymo 4a2c153
Address PR quick-fix feedback: use SUPPORTED_SNAP_CAPABILITIES for snap
pablodeymo eaf2a8c
Convert snap client methods from PeerHandler extension to standalone …
pablodeymo 6f12101
Merge branch 'main' into feature/slack-phase-breakdown
pablodeymo 6e87eb2
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo 8e06aa5
Move snap_server_tests from crates/networking/p2p/tests/ to test/test…
pablodeymo 48c39cc
Merge branch 'main' into refactor/snapsync-healing-unification
pablodeymo b571e36
Use SUPPORTED_SNAP_CAPABILITIES for snap client peer selection
pablodeymo 216ee7f
Merge branch 'main' into feature/slack-phase-breakdown
pablodeymo 9bc7a4d
Merge remote-tracking branch 'origin/refactor/snapsync-healing-unific…
pablodeymo b8bf73a
Merge remote-tracking branch 'origin/feature/slack-phase-breakdown' i…
pablodeymo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description/title suggest a small peer-capability selection fix, but this change set introduces a much broader refactor (new public
snapmodule, new sync submodules, moved tests, error type changes). Please update the PR description/scope (or split into separate PRs) so reviewers can reason about risk and intent accurately.