fix: reject unsupported filter argument in add_columns#5187
Open
LuciferYang wants to merge 1 commit into
Open
Conversation
The filter parameter was accepted and documented but never used, so any filter was silently dropped and every fragment was processed. Raise NotImplementedError instead of silently ignoring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_columnstakes afilterargument and documents it, but nothing in the function body ever uses it. The filter is silently dropped and every fragment is processed anyway, so a call that looks like it's narrowing the work quietly does the opposite.Instead of ignoring it,
add_columnsnow raisesNotImplementedErrorwhenfilteris notNone, and the docstring is updated to note the argument is reserved for whenget_fragmentssupports filtering. The defaultfilter=Nonepath is unchanged.Added a test that asserts passing a filter raises; the existing test still covers the normal
filter=Noneflow.