fix: optimize count over non-null constants#155
Open
LuciferYang wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I'll resolve these conflicting PRs when I get back next week. |
Treat COUNT(non-null constant) as a row-count aggregate so it can use the existing manifest-backed fast path. Keep filtered, distinct, NULL, column, sorted, and grouped aggregates out of this optimization. Fixes lance-format#142
LuciferYang
force-pushed
the
fix/142-count-constant-pushdown
branch
from
cc67553 to
6c1c232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COUNT(non-null constant)as a row-count aggregate so it can use the existing manifest-backed count fast path.Fixes #142
Verification
git diff --checkJAVA_HOME=/Users/yangjie01/Tools/zulu25 ./mvnw test -pl plugin/trino-lance -Dtest=TestLanceMetadata#testCountNonNullConstantAggregationPushdown+testCountNullConstantAggregationNotPushedDown+testFilteredCountConstantAggregationNotPushedDown+testCountConstantAggregationWithTableFilterNotPushedDown+testDistinctCountConstantAggregationNotPushedDown+testCountColumnAggregationNotPushedDown+testSortedCountConstantAggregationNotPushedDown,TestLanceConnectorTest#testCountNonNullConstantPushdown -Dair.check.skip-enforcer=true -Dsurefire.forkCount=1