Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/landingai_ade/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import annotations

import os
import json
import importlib.metadata
from typing import TYPE_CHECKING, Any, Dict, Union, Mapping, Iterable, Optional, cast
from pathlib import Path
Expand Down Expand Up @@ -559,7 +560,7 @@ def parse(
def split(
self,
*,
split_class: Iterable[client_split_params.SplitClass],
split_class: Union[str, Iterable[client_split_params.SplitClass]],
markdown: Union[FileTypes, str, None] | Omit = omit,
markdown_url: Optional[str] | Omit = omit,
model: Optional[str] | Omit = omit,
Expand Down Expand Up @@ -606,9 +607,10 @@ def split(
# Store original inputs for filename extraction
original_markdown = markdown
original_markdown_url = markdown_url
normalized_split_class = split_class if isinstance(split_class, str) else json.dumps(list(split_class))
body = deepcopy_minimal(
{
"split_class": split_class,
"split_class": normalized_split_class,
"markdown": markdown,
"markdown_url": markdown_url,
"model": model,
Expand Down Expand Up @@ -1080,7 +1082,7 @@ async def parse(
async def split(
self,
*,
split_class: Iterable[client_split_params.SplitClass],
split_class: Union[str, Iterable[client_split_params.SplitClass]],
markdown: Union[FileTypes, str, None] | Omit = omit,
markdown_url: Optional[str] | Omit = omit,
model: Optional[str] | Omit = omit,
Expand Down Expand Up @@ -1119,9 +1121,10 @@ async def split(

timeout: Override the client-level default timeout for this request, in seconds
"""
normalized_split_class = split_class if isinstance(split_class, str) else json.dumps(list(split_class))
body = deepcopy_minimal(
{
"split_class": split_class,
"split_class": normalized_split_class,
"markdown": markdown,
"markdown_url": markdown_url,
"model": model,
Expand Down
2 changes: 1 addition & 1 deletion src/landingai_ade/types/client_split_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@


class ClientSplitParams(TypedDict, total=False):
split_class: Required[Iterable[SplitClass]]
split_class: Required[Union[str, Iterable[SplitClass]]]
"""List of split classification options/configuration.

Can be provided as JSON string in form data.
Expand Down
24 changes: 24 additions & 0 deletions tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,30 @@ def test_multipart_repeating_array(self, client: LandingAIADE) -> None:
b"",
]

def test_split_sends_split_class_as_json_string_in_multipart(self, client: LandingAIADE) -> None:
request = client._build_request(
FinalRequestOptions.construct(
method="post",
url="/v1/ade/split",
headers={"Content-Type": "multipart/form-data; boundary=6b7ba517decee4a450543ea6ae821c82"},
json_data={"split_class": json.dumps([{"name": "Bank Statement"}]), "markdown": "# doc"},
files=(),
)
)

assert request.read().split(b"\r\n") == [
b"--6b7ba517decee4a450543ea6ae821c82",
b'Content-Disposition: form-data; name="split_class"',
b"",
b'[{"name": "Bank Statement"}]',
b"--6b7ba517decee4a450543ea6ae821c82",
b'Content-Disposition: form-data; name="markdown"',
b"",
b"# doc",
b"--6b7ba517decee4a450543ea6ae821c82--",
b"",
]

@pytest.mark.respx(base_url=base_url)
def test_binary_content_upload(self, respx_mock: MockRouter, client: LandingAIADE) -> None:
respx_mock.post("/upload").mock(side_effect=mirror_request_content)
Expand Down