Skip to content

The s3 signature_version supports transparent passing of environment #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jint-Tian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

The s3 signature_version supports transparent passing of environment #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a29cd0
The s3 signature_version supports transparent passing of environment
Jul 12, 2025
5797433
default v4
Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func initOSS(config *app.Config) oss.OSS {
Bucket: config.PluginStorageOSSBucket,
Region: config.AWSRegion,
UseIamRole: config.S3UseAwsManagedIam,
SignatureVersion: config.S3SignatureVersion,
},
TencentCOS: &oss.TencentCOS{
Region: config.TencentCOSRegion,
Expand Down
1 change: 1 addition & 0 deletions internal/types/app/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type Config struct {
S3UseAWS bool `envconfig:"S3_USE_AWS" default:"true"`
S3Endpoint string `envconfig:"S3_ENDPOINT"`
S3UsePathStyle bool `envconfig:"S3_USE_PATH_STYLE" default:"true"`
S3SignatureVersion string `envconfig:"S3_SIGNATURE_VERSION" default:"v4"`
Copy link
Copy Markdown
Contributor

@fatelei fatelei Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default value should be s3v4

AWSAccessKey string `envconfig:"AWS_ACCESS_KEY"`
AWSSecretKey string `envconfig:"AWS_SECRET_KEY"`
AWSRegion string `envconfig:"AWS_REGION"`
Expand Down