feat: support dify DataSourceResponseChunkTypeBinaryLink#669
Open
fatelei wants to merge 1 commit intolanggenius:mainfrom
Open
feat: support dify DataSourceResponseChunkTypeBinaryLink#669fatelei wants to merge 1 commit intolanggenius:mainfrom
fatelei wants to merge 1 commit intolanggenius:mainfrom
Conversation
dosubot
bot
added
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the BinaryLink response chunk type to the datasource_entities and tool_entities packages and updates the corresponding validation logic. Feedback suggests centralizing these shared types into a common package to eliminate code duplication and ensure consistency.
| ToolResponseChunkTypeLink ToolResponseChunkType = "link" | ||
| ToolResponseChunkTypeImage ToolResponseChunkType = "image" | ||
| ToolResponseChunkTypeImageLink ToolResponseChunkType = "image_link" | ||
| ToolResponseChunkTypeBinaryLink ToolResponseChunkType = "binary_link" |
Contributor
There was a problem hiding this comment.
The BinaryLink chunk type is being added to both datasource_entities and tool_entities. These two packages appear to maintain identical sets of response chunk types. Consider centralizing these shared types into a common package to reduce duplication and ensure consistency across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #200
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.