Skip to content

feat : set the time zone for the service#682

Merged
fatelei merged 4 commits intolanggenius:mainfrom
shootercheng:feature/server_timezone
Apr 13, 2026
Merged

feat : set the time zone for the service#682
fatelei merged 4 commits intolanggenius:mainfrom
shootercheng:feature/server_timezone

Conversation

@shootercheng
Copy link
Copy Markdown
Contributor

Description

set the time zone for the service, with UTC as the default time zone

SERVER_TZ=Asia/Shanghai

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

2026-04-07T22:18:31.465134154+08:00 INFO dify-plugin-daemon pool.go:34 init routine pool size=1024
2026-04-07T22:18:31.470927004+08:00 INFO dify-plugin-daemon init.go:120 dify plugin db initialized
2026-04-07T22:18:31.471219729+08:00 INFO dify-plugin-daemon manager.go:118 start plugin manager daemon
2026-04-07T22:18:31.474474739+08:00 INFO dify-plugin-daemon init.go:20 persistence initialized
2026-04-07T22:18:31.474547401+08:00 INFO dify-plugin-daemon server_local.go:16 start to handle new plugins path=plugin

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request go Pull requests that update go code plugin-daemon labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for a configurable server timezone by adding a SERVER_TZ environment variable and updating the configuration logic to set the global time.Local during startup. The logging system was also modified to use local time for record timestamps. Feedback indicates that the initialization sequence in main.go should be re-evaluated, as performing configuration validation and timezone setup before initializing the logger and recovery mechanism may prevent startup errors from being correctly captured and formatted.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 7, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2026
@fatelei fatelei merged commit 1ca8931 into langgenius:main Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants