Filter orphan tool calls when rehydrating database conversations#679
Draft
Anoop-Kadachi wants to merge 1 commit into
Draft
Filter orphan tool calls when rehydrating database conversations#679Anoop-Kadachi wants to merge 1 commit into
Anoop-Kadachi wants to merge 1 commit into
Conversation
Member
|
can you fix conflicts ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #639.
DatabaseConversationStore::getLatestConversationMessages()currently rehydrates every stored tool call on an assistant row, even if that tool call has no matching tool result.That can happen when a multi-step agent turn hits its
maxStepslimit after the model has requested tools, but before those tool calls are executed. The assistant message can then be stored with pendingtool_callsand no correspondingtool_results.On the next prompt, the stored conversation history is replayed with orphan tool-use IDs. Providers such as Anthropic reject that history with: