-
-
Notifications
You must be signed in to change notification settings - Fork 3
Enhanced OS independent CPU and FPU detection #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xecc0-devices
wants to merge
18
commits into
larsonmars:main
Choose a base branch
from
0xecc0-devices:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b943000
* MC68030, MC68040, MC68060 and AC68080 CPU detection for independent…
0xecc0-devices d149a45
- added credits into the source code
0xecc0-devices be71bcc
Merge branch 'larsonmars:main' into main
0xecc0-devices 1a2422a
Enhanced OS independent CPU and FPU detection
0xecc0-devices 1b7e064
Merge branch 'main' of https://github.com/0xecc0-devices/sysvars
0xecc0-devices 689bc30
Fixed fpu detection crash on plain 68000 machines
0xecc0-devices 1cdd6e4
Update README.md
0xecc0-devices 2e16499
Update README.md
0xecc0-devices 8191ea3
Update README.md
0xecc0-devices b727963
Added UAE/Musashi/Emu68 detection
0xecc0-devices 37a7925
Merge branch 'main' of https://github.com/0xecc0-devices/sysvars
0xecc0-devices d92dff9
updated README.md
0xecc0-devices f375f86
Fix: Added code to properly close the expansion.library after detecti…
0xecc0-devices a904b9c
sysvars 0.23
0xecc0-devices 01c599d
Update README.md
0xecc0-devices 82a9345
Update README.md
0xecc0-devices 744d834
- changes according to https://github.com/larsonmars/sysvars/pull/18
0xecc0-devices 030fb32
Merge branch 'main' of https://github.com/0xecc0-devices/sysvars
0xecc0-devices File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like with the CPU, this is a breaking change. Is there a reason why you changed the FPU to be always available again? The inital sysvars version also had this defined always. I had this later changed to be not defined for CPUs below MC68020 so it is consistent with other properties that are only defined when they can technically be available. AFAIK, there can never be any FPU with anything below MC68020, but maybe I'm wrong. Also, why is 'none' better then just empty?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to have an FPU with the 68000 as a peripheral (see Motorola AN947). But it's rather impractical.
In Amiga DOS scripts you would probably go for
IF EXISTSchecking for the availability of the environment variable and then compare the value withIF $FPU EQor something similar.I think script-wise there's no real difference between checking for existance of the variable or getting it's value evaluated.
I'll just revoke the change that sets the variable when there's no FPU detected.