Fix list iteration in claim format validation#375
Merged
Conversation
Update the validation logic to iterate over the items in claims[name] rather than the claims dictionary itself. This fixes a bug where list-based claims (such as multiple audiences) were not correctly checking if all elements were strings. A test for 'aud' claim type validation has been added to prevent future regressions. Co-authored-by: Gemini <gemini@google.com> Signed-off-by: Simo Sorce <simo@redhat.com>
Add Python 3.14 to the tox environment testing list to ensure compatibility with the upcoming Python release. Additionally, update the basepython version from 3.13 to 3.14 for all utility and documentation environments (lint, pep8, doc, sphinx, doctest, codespell) to utilize the newest interpreter. Signed-off-by: Simo Sorce <simo@redhat.com>
Add Python 3.14 to the GitHub Actions test matrix to ensure compatibility with the upcoming release. Set Python 3.14 as the default version for utility jobs like linting, docs, and formatting. Additionally, upgrade actions/checkout and actions/setup-python to v6 to keep workflow dependencies current. Signed-off-by: Simo Sorce <simo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the validation logic to iterate over the items in claims[name] rather than the claims dictionary itself. This fixes a bug where list-based claims (such as multiple audiences) were not correctly checking if all elements were strings. A test for 'aud' claim type validation has been added to prevent future regressions.
Credit to @0xHunSec for reporting this although it was rejected as a security issue, because this flaw gives no security bypass abilities, it is just a bug.