feat(world): add CallWithSignatureSystem - #3496
Conversation
|
| @@ -0,0 +1,174 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // OpenZeppelin Contracts (last updated v5.0.0) (utils/cryptography/ECDSA.sol) | |||
There was a problem hiding this comment.
did we decide it was better to copy/paste these here instead of importing from OZ as a dep?
if we keep this here, maybe should put these in a vendor or similar directory to better isolate unchanged and already audited copy/pasted source files?
There was a problem hiding this comment.
I think the original reason was that the OZ package was a pretty heavy dependency and we only needed very few files from it. At this point we do have a couple vendored OZ files in the world package (ERC165Checker, IERC1967, Proxy, StorageSlot) but I don't think it's worth changing our approach now. MUD is audited as a whole and the auditors can easily check that the files match the original sources. Changing paths of a Solidity package is always annoying because it would break things downstream if the files are imported since there are no explicit exports/remappings.
There was a problem hiding this comment.
I hope no one has imported these directly 🙈 wonder if we should start putting not-for-external-use source files into internal dirs, like we've started doing for TS exports
448a8c7 to
caeb019
Compare
caeb019 to
8c2960b
Compare
Co-authored-by: Kevin Ingersoll <kingersoll@gmail.com>
6d20d2a to
80137a4
Compare
|
combining all changes that require an audit into #3630 |
closes #3437