Skip to content

fix(common): skip formatting on solidity error - #3662

Merged
alvrs merged 4 commits into
latticexyz:mainfrom
dk1a:dk1a/nonhalting-format-solidity
Apr 17, 2025
Merged

fix(common): skip formatting on solidity error#3662
alvrs merged 4 commits into
latticexyz:mainfrom
dk1a:dk1a/nonhalting-format-solidity

Conversation

@dk1a

@dk1a dk1a commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

This is relevant for debugging solidity errors in codegen's own output (like with #3661)
Or when someone uses solidity keywords in mud config

formatSolidity throws very useless errors, and codegen neither reports which file gave the error, nor shows the code with the error

This change lets formatAndWriteSolidity output files even with solidity errors (but unformatted), so forge build can properly report what's wrong

@dk1a
dk1a requested a review from alvrs as a code owner April 10, 2025 19:20
@changeset-bot

changeset-bot Bot commented Apr 10, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d113a43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/common Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/entrykit Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/protocol-parser Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/react Patch
@latticexyz/world-consumer Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-metadata Patch
@latticexyz/abi-ts Patch
create-mud Patch
@latticexyz/gas-report Patch
@latticexyz/paymaster Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch
vite-plugin-mud Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants