Skip to content

chore: rename trackLatency to trackDuration on LDGraphTracker #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsonbailey wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: rename trackLatency to trackDuration on LDGraphTracker #1285

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7745852
fix: Add support for graph metric tracking (#1269)
jsonbailey Apr 14, 2026
d640d8e
feat!: Add per-execution runId, at-most-once tracking, and cross-proc…
jsonbailey Apr 15, 2026
367d369
chore: Move graphKey to LDAIConfigTracker constructor (#1279)
jsonbailey Apr 16, 2026
42fb587
chore: rename trackLatency to trackDuration on LDGraphTracker, update…
jsonbailey Apr 16, 2026
cfb4846
chore: correct trackDuration event key to $ld:ai:graph:duration:total
jsonbailey Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 22 additions & 52 deletions packages/sdk/server-ai/__tests__/Judge.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ describe('Judge', () => {
],
model: { name: 'gpt-4' },
provider: { name: 'openai' },
tracker: mockTracker,
createTracker: () => mockTracker,
evaluationMetricKey: 'relevance',
};
});

describe('constructor', () => {
it('initializes with proper configuration', () => {
const judge = new Judge(judgeConfig, mockTracker, mockProvider, mockLogger);
const judge = new Judge(judgeConfig, mockProvider, mockLogger);

expect(judge).toBeDefined();
});
Expand All @@ -64,7 +64,7 @@ describe('Judge', () => {
let judge: Judge;

beforeEach(() => {
judge = new Judge(judgeConfig, mockTracker, mockProvider, mockLogger);
judge = new Judge(judgeConfig, mockProvider, mockLogger);
});

it('evaluates AI response successfully', async () => {
Expand Down Expand Up @@ -209,12 +209,7 @@ describe('Judge', () => {
evaluationMetricKey: undefined,
evaluationMetricKeys: [],
};
const judgeWithoutMetrics = new Judge(
configWithoutMetrics,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithoutMetrics = new Judge(configWithoutMetrics, mockProvider, mockLogger);

const result = await judgeWithoutMetrics.evaluate('test input', 'test output');

Expand All @@ -231,12 +226,7 @@ describe('Judge', () => {
evaluationMetricKey: 'relevance',
evaluationMetricKeys: undefined,
};
const judgeWithSingleKey = new Judge(
configWithSingleKey,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithSingleKey = new Judge(configWithSingleKey, mockProvider, mockLogger);

const mockStructuredResponse: StructuredResponse = {
data: {
Expand Down Expand Up @@ -275,12 +265,7 @@ describe('Judge', () => {
evaluationMetricKey: undefined,
evaluationMetricKeys: ['relevance', 'accuracy'],
};
const judgeWithLegacyKeys = new Judge(
configWithLegacyKeys,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithLegacyKeys = new Judge(configWithLegacyKeys, mockProvider, mockLogger);

const mockStructuredResponse: StructuredResponse = {
data: {
Expand Down Expand Up @@ -319,12 +304,7 @@ describe('Judge', () => {
evaluationMetricKey: undefined,
evaluationMetricKeys: ['', ' ', 'relevance', 'accuracy'],
};
const judgeWithInvalidKeys = new Judge(
configWithInvalidKeys,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithInvalidKeys = new Judge(configWithInvalidKeys, mockProvider, mockLogger);

const mockStructuredResponse: StructuredResponse = {
data: {
Expand Down Expand Up @@ -364,7 +344,7 @@ describe('Judge', () => {
evaluationMetricKey: 'helpfulness',
evaluationMetricKeys: ['relevance', 'accuracy'],
};
const judgeWithBoth = new Judge(configWithBoth, mockTracker, mockProvider, mockLogger);
const judgeWithBoth = new Judge(configWithBoth, mockProvider, mockLogger);

const mockStructuredResponse: StructuredResponse = {
data: {
Expand Down Expand Up @@ -402,12 +382,7 @@ describe('Judge', () => {
...judgeConfig,
messages: undefined,
};
const judgeWithoutMessages = new Judge(
configWithoutMessages,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithoutMessages = new Judge(configWithoutMessages, mockProvider, mockLogger);

const result = await judgeWithoutMessages.evaluate('test input', 'test output');

Expand Down Expand Up @@ -511,7 +486,7 @@ describe('Judge', () => {
let judge: Judge;

beforeEach(() => {
judge = new Judge(judgeConfig, mockTracker, mockProvider, mockLogger);
judge = new Judge(judgeConfig, mockProvider, mockLogger);
});

it('evaluates messages and response successfully', async () => {
Expand Down Expand Up @@ -596,7 +571,7 @@ describe('Judge', () => {
let judge: Judge;

beforeEach(() => {
judge = new Judge(judgeConfig, mockTracker, mockProvider, mockLogger);
judge = new Judge(judgeConfig, mockProvider, mockLogger);
});

it('constructs evaluation messages correctly', () => {
Expand All @@ -621,7 +596,7 @@ describe('Judge', () => {
let judge: Judge;

beforeEach(() => {
judge = new Judge(judgeConfig, mockTracker, mockProvider, mockLogger);
judge = new Judge(judgeConfig, mockProvider, mockLogger);
});

it('parses valid evaluation response correctly', () => {
Expand All @@ -633,7 +608,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({
relevance: { score: 0.8, reasoning: 'Good' },
Expand All @@ -647,7 +622,7 @@ describe('Judge', () => {
relevance: { score: 0.8, reasoning: 'Good' },
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
});
Expand All @@ -661,7 +636,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
});
Expand All @@ -675,7 +650,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand All @@ -693,7 +668,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand All @@ -711,7 +686,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand All @@ -729,7 +704,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand All @@ -744,12 +719,7 @@ describe('Judge', () => {
evaluationMetricKey: undefined,
evaluationMetricKeys: [],
};
const judgeWithEmptyKeys = new Judge(
configWithEmptyKeys,
mockTracker,
mockProvider,
mockLogger,
);
const judgeWithEmptyKeys = new Judge(configWithEmptyKeys, mockProvider, mockLogger);

const result = await judgeWithEmptyKeys.evaluate('test input', 'test output');

Expand All @@ -769,7 +739,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand All @@ -787,7 +757,7 @@ describe('Judge', () => {
},
};

const result = parseResponse(responseData, 'relevance');
const result = parseResponse(responseData, 'relevance', mockTracker);

expect(result).toEqual({});
expect(mockLogger.warn).toHaveBeenCalledWith(
Expand Down
Loading
Loading