feat: Add test harness support for flag change listeners in Server SDKs

docs/service_spec.md

@@ -199,6 +199,17 @@ A test hook must:
       * `stage` (string, optional): If executing a stage, for example `beforeEvaluation`, this should be the stage.
   - Return data from the stages as specified via the `data` configuration. For instance the return value from the `beforeEvaluation` hook should be `data['beforeEvaluation']` merged with the input data for the stage.
 
+#### Capability `"flag-change-listeners"`
+
+This means that the SDK has support for general flag change listeners — listeners that are notified when any flag's configuration changes. When a flag changes, the SDK test service should POST notification data to the callback URI provided during listener registration.
+
+For details on the commands and callback payloads, see the `registerFlagChangeListener` and `unregisterListener` commands.
+
+#### Capability `"flag-value-change-listeners"`
+
+This means that the SDK has a native API for flag *value* change listeners — listeners that are notified when a specific flag's evaluated value changes for a given context. Not all SDKs provide this API; for example, the Node.js server SDK only supports general flag change listeners.
+
+For details on the commands and callback payloads, see the `registerFlagValueChangeListener` and `unregisterListener` commands.
 
 #### Capability `"tls:verify-peer"`
 

mockld/listener_callback_service.go

@@ -0,0 +1,69 @@
+package mockld
+
+import (
+	"encoding/json"
+	"io"
+	"net/http"
+
+	"github.com/launchdarkly/sdk-test-harness/v2/framework"
+	"github.com/launchdarkly/sdk-test-harness/v2/framework/harness"
+	"github.com/launchdarkly/sdk-test-harness/v2/servicedef"
+)
+
+// ListenerCallbackService is a mock HTTP server that receives flag change listener notifications
+// POSTed by an SDK test service. Each registered listener should have its own instance so that
+// notifications can be attributed to the correct listener in test assertions.
+type ListenerCallbackService struct {
+	payloadEndpoint *harness.MockEndpoint
+	CallChannel     chan servicedef.ListenerNotification
+}
+
+// GetURL returns the callback URI to provide when registering a listener. The SDK test service
+// will POST a ListenerNotification JSON body to this URL when the listener fires.
+func (l *ListenerCallbackService) GetURL() string {
+	return l.payloadEndpoint.BaseURL()
+}
+
+// Close shuts down the mock HTTP endpoint and releases its resources.
+func (l *ListenerCallbackService) Close() {
+	l.payloadEndpoint.Close()
+}
+
+// NewListenerCallbackService creates a ListenerCallbackService with a mock HTTP endpoint
+// ready to receive notifications. Call Close() when done.
+func NewListenerCallbackService(
+	testHarness *harness.TestHarness,
+	logger framework.Logger,
+) *ListenerCallbackService {
+	l := &ListenerCallbackService{
+		CallChannel: make(chan servicedef.ListenerNotification),
+	}
+
+	endpointHandler := http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+		bytes, err := io.ReadAll(req.Body)
+		logger.Printf("Received listener notification: %s", string(bytes))
+		if err != nil {
+			logger.Printf("Could not read body from listener callback.")
+			w.WriteHeader(http.StatusBadRequest)
+			return
+		}
+		var notification servicedef.ListenerNotification
+		err = json.Unmarshal(bytes, &notification)
+		if err != nil {
+			logger.Printf("Could not unmarshal listener notification.")
+			w.WriteHeader(http.StatusBadRequest)
+			return
+		}
+
+		go func() {
+			l.CallChannel <- notification
+		}()
+
+		w.WriteHeader(http.StatusOK)
+	})
+
+	l.payloadEndpoint = testHarness.NewMockEndpoint(
+		endpointHandler, logger, harness.MockEndpointDescription("listener notification"))
+
+	return l
+}

sdktests/common_tests_listeners.go

@@ -0,0 +1,287 @@
+package sdktests
+
+import (
+	"github.com/launchdarkly/go-test-helpers/v2/jsonhelpers"
+
+	"github.com/launchdarkly/go-sdk-common/v3/ldattr"
+	"github.com/launchdarkly/go-sdk-common/v3/ldcontext"
+	"github.com/launchdarkly/go-sdk-common/v3/ldvalue"
+	"github.com/launchdarkly/go-server-sdk-evaluation/v3/ldbuilders"
+	"github.com/launchdarkly/go-server-sdk-evaluation/v3/ldmodel"
+
+	"github.com/launchdarkly/sdk-test-harness/v2/framework/ldtest"
+	"github.com/launchdarkly/sdk-test-harness/v2/mockld"
+	"github.com/launchdarkly/sdk-test-harness/v2/servicedef"
+)
+
+func doCommonListenerTests(t *ldtest.T) {
+	t.Run("flag change listener", doFlagChangeListenerTests)
+	t.Run("flag value change listener", doFlagValueChangeListenerTests)
+}
+
+func doFlagChangeListenerTests(t *ldtest.T) {
+	t.RequireCapability(servicedef.CapabilityFlagChangeListeners)
+	t.Run("receives notification when flag changes", flagChangeListenerReceivesNotification)
+	t.Run("fires on config change even when value unchanged", flagChangeListenerFiresOnConfigChange)
+	t.Run("receives notifications for different flags", flagChangeListenerReceivesDifferentFlags)
+}
+
+func doFlagValueChangeListenerTests(t *ldtest.T) {
+	t.RequireCapability(servicedef.CapabilityFlagValueChangeListeners)
+	t.Run("receives notification when value changes", flagValueChangeListenerReceivesNotification)
+	t.Run("does not notify when value is unchanged", flagValueChangeListenerNoNotificationWhenUnchanged)
+	t.Run("multiple listeners both receive notification", flagValueChangeListenerMultipleBothNotified)
+	t.Run("is context specific", flagValueChangeListenerIsContextSpecific)
+	t.Run("reports correct old and new JSON values", flagValueChangeListenerJSONValues)
+}
+
+// makeFlagForFlagChangeListenerTests builds a server-side feature flag for listener tests. The flag
+// evaluates to value as its off-variation, so any context will receive that value.
+func makeFlagForFlagChangeListenerTests(key string, version int, value ldvalue.Value) ldmodel.FeatureFlag {
+	return ldbuilders.NewFlagBuilder(key).Version(version).
+		On(false).OffVariation(0).Variations(value, ldvalue.String("other")).Build()
+}
+
+// createClientForFlagChangeListenerTests sets up a client with two flags (flag1 and flag2) pre-loaded
+// via streaming, both initially evaluating to "value1". Use dataSystem.Synchronizers[0].streaming
+// to push flag updates and trigger listener notifications.
+func createClientForFlagChangeListenerTests(t *ldtest.T) (*SDKClient, *SDKDataSystem) {
+	flag1 := makeFlagForFlagChangeListenerTests("flag1", 1, ldvalue.String("value1"))
+	flag2 := makeFlagForFlagChangeListenerTests("flag2", 1, ldvalue.String("value1"))
+	data := mockld.NewServerSDKDataBuilder().Flag(flag1, flag2).Build()
+
+	dataSystem := NewSDKDataSystem(t, data)
+	client := NewSDKClient(t, dataSystem)
+
+	return client, dataSystem
+}
+
+// pushFlagUpdateForFlagChangeListenerTests pushes a flag update through the streaming service and
+// signals that the payload is complete. version must increase with each call; it is used as both the
+// flag version and the payload-transferred sequence number.
+func pushFlagUpdateForFlagChangeListenerTests(dataSystem *SDKDataSystem, key string, version int, value ldvalue.Value) {
+	flag := makeFlagForFlagChangeListenerTests(key, version, value)
+
+	streaming := dataSystem.Synchronizers[0].streaming
+	streaming.PushUpdate("flag", key, version, jsonhelpers.ToJSON(flag))
+	streaming.PushPayloadTransferred("updated", version)
+}
+
+// --- Flag change listener tests ---
+
+func flagChangeListenerReceivesNotification(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagChangeListener(t, servicedef.RegisterFlagChangeListenerParams{
+		ListenerID:  "listener-1",
+		CallbackURI: callback.GetURL(),
+	})
+
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, ldvalue.String("new-value"))
+
+	callback.ExpectFlagChangeNotification(t, "flag1")
+}
+
+func flagChangeListenerFiresOnConfigChange(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagChangeListener(t, servicedef.RegisterFlagChangeListenerParams{
+		ListenerID:  "listener-1",
+		CallbackURI: callback.GetURL(),
+	})
+
+	// Push an update that changes the flag's version but not its evaluated value.
+	// The general flag change listener must fire regardless of value changes, because
+	// it tracks configuration changes (e.g. targeting rule edits), not just value changes.
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, ldvalue.String("value1"))
+
+	callback.ExpectFlagChangeNotification(t, "flag1")
+}
+
+func flagChangeListenerReceivesDifferentFlags(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagChangeListener(t, servicedef.RegisterFlagChangeListenerParams{
+		ListenerID:  "listener-1",
+		CallbackURI: callback.GetURL(),
+	})
+
+	// Update flag1 — listener should fire.
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, ldvalue.String("new-value"))
+	callback.ExpectFlagChangeNotification(t, "flag1")
+
+	// Update flag2 — listener should fire again for the different flag.
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag2", 3, ldvalue.String("new-value"))
+	callback.ExpectFlagChangeNotification(t, "flag2")
+}
+
+// --- Flag value change listener tests ---
+
+func flagValueChangeListenerReceivesNotification(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	context := ldcontext.New("user-key")
+	oldValue := ldvalue.String("value1")
+	newValue := ldvalue.String("new-value")
+	defaultValue := ldvalue.String("default")
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-1",
+		FlagKey:      "flag1",
+		Context:      context,
+		DefaultValue: defaultValue,
+		CallbackURI:  callback.GetURL(),
+	})
+
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, newValue)
+
+	callback.ExpectValueChangeNotification(t, "flag1", oldValue, newValue)
+}
+
+func flagValueChangeListenerNoNotificationWhenUnchanged(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	context := ldcontext.New("user-key")
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-1",
+		FlagKey:      "flag1",
+		Context:      context,
+		DefaultValue: ldvalue.String("default"),
+		CallbackURI:  callback.GetURL(),
+	})
+
+	// Update flag1 with a new version but the same evaluated value — should NOT trigger notification.
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, ldvalue.String("value1"))
+	callback.ExpectNoNotification(t, "flag1")
+}
+
+func flagValueChangeListenerMultipleBothNotified(t *ldtest.T) {
+	client, dataSystem := createClientForFlagChangeListenerTests(t)
+
+	context := ldcontext.New("user-key")
+	oldValue := ldvalue.String("value1")
+	newValue := ldvalue.String("new-value")
+	defaultValue := ldvalue.String("default")
+
+	callback1 := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback1.Close()
+	callback2 := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback2.Close()
+
+	// Register two independent listeners for the same flag and context.
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-1",
+		FlagKey:      "flag1",
+		Context:      context,
+		DefaultValue: defaultValue,
+		CallbackURI:  callback1.GetURL(),
+	})
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-2",
+		FlagKey:      "flag1",
+		Context:      context,
+		DefaultValue: defaultValue,
+		CallbackURI:  callback2.GetURL(),
+	})
+
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, newValue)
+
+	// Both listeners must receive the notification independently.
+	callback1.ExpectValueChangeNotification(t, "flag1", oldValue, newValue)
+	callback2.ExpectValueChangeNotification(t, "flag1", oldValue, newValue)
+}
+
+func flagValueChangeListenerIsContextSpecific(t *ldtest.T) {
+	context1 := ldcontext.New("user-1")
+	context2 := ldcontext.New("user-2")
+	defaultValue := ldvalue.String("default")
+
+	// Initially both contexts see "value1" (flag is off, returns the same off-variation for all).
+	flag1 := makeFlagForFlagChangeListenerTests("flag1", 1, ldvalue.String("value1"))
+	data := mockld.NewServerSDKDataBuilder().Flag(flag1).Build()
+	dataSystem := NewSDKDataSystem(t, data)
+	client := NewSDKClient(t, dataSystem)
+
+	callback1 := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback1.Close()
+	callback2 := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback2.Close()
+
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-1",
+		FlagKey:      "flag1",
+		Context:      context1,
+		DefaultValue: defaultValue,
+		CallbackURI:  callback1.GetURL(),
+	})
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-2",
+		FlagKey:      "flag1",
+		Context:      context2,
+		DefaultValue: defaultValue,
+		CallbackURI:  callback2.GetURL(),
+	})
+
+	// Push an updated flag that returns "updated-value" for user-1 via a targeting rule,
+	// and "value1" (unchanged) for everyone else via the fallthrough.
+	updatedFlag := ldbuilders.NewFlagBuilder("flag1").Version(2).
+		On(true).
+		FallthroughVariation(0).
+		Variations(ldvalue.String("value1"), ldvalue.String("updated-value")).
+		AddRule(ldbuilders.NewRuleBuilder().ID("target-rule").Variation(1).Clauses(
+			ldbuilders.Clause(ldattr.KeyAttr, ldmodel.OperatorIn, ldvalue.String("user-1")),
+		)).
+		Build()
+
+	streaming := dataSystem.Synchronizers[0].streaming
+	streaming.PushUpdate("flag", "flag1", 2, jsonhelpers.ToJSON(updatedFlag))
+	streaming.PushPayloadTransferred("updated", 2)
+
+	// context1 (user-1): value changed from "value1" to "updated-value" → notification expected.
+	callback1.ExpectValueChangeNotification(t, "flag1", ldvalue.String("value1"), ldvalue.String("updated-value"))
+
+	// context2 (user-2): value unchanged ("value1" → "value1") → no notification expected.
+	callback2.ExpectNoNotification(t, "flag1")
+}
+
+func flagValueChangeListenerJSONValues(t *ldtest.T) {
+	oldValue := ldvalue.ObjectBuild().Set("color", ldvalue.String("red")).Set("count", ldvalue.Int(1)).Build()
+	newValue := ldvalue.ObjectBuild().Set("color", ldvalue.String("blue")).Set("count", ldvalue.Int(2)).Build()
+	defaultValue := ldvalue.ObjectBuild().Build()
+
+	flag := makeFlagForFlagChangeListenerTests("flag1", 1, oldValue)
+	data := mockld.NewServerSDKDataBuilder().Flag(flag).Build()
+	dataSystem := NewSDKDataSystem(t, data)
+	client := NewSDKClient(t, dataSystem)
+
+	callback := NewListenerCallback(requireContext(t).harness, t.DebugLogger())
+	defer callback.Close()
+
+	client.RegisterFlagValueChangeListener(t, servicedef.RegisterFlagValueChangeListenerParams{
+		ListenerID:   "listener-1",
+		FlagKey:      "flag1",
+		Context:      ldcontext.New("user-key"),
+		DefaultValue: defaultValue,
+		CallbackURI:  callback.GetURL(),
+	})
+
+	pushFlagUpdateForFlagChangeListenerTests(dataSystem, "flag1", 2, newValue)
+
+	callback.ExpectValueChangeNotification(t, "flag1", oldValue, newValue)
+}