Skip to content

Fix security issues, clean Rust warnings, restore UTF-8 locales, and improve account UX/performance#3179

Open
Vucius wants to merge 8 commits into
lbjlaq:mainfrom
Vucius:clean_warn
Open

Fix security issues, clean Rust warnings, restore UTF-8 locales, and improve account UX/performance#3179
Vucius wants to merge 8 commits into
lbjlaq:mainfrom
Vucius:clean_warn

Conversation

@Vucius

@Vucius Vucius commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR focuses on eliminating compiler warnings, improving backend security, fixing locale encoding/formatting issues, and optimizing frontend performance and user experience (UX) during account operations.

Key Changes

1. Security & Backend Fixes

  • Path Traversal Prevention: Exposed validate_user_json_path in src-tauri/src/commands/mod.rs and integrated it into log export commands (export_proxy_logs and export_proxy_logs_json in proxy.rs) to validate target file paths before writing files.
  • Refactoring Fixes: Removed redundant braces left behind during a previous refactoring in src-tauri/src/modules/account.rs.
  • User Tips Update: Updated startup hints in src-tauri/src/lib.rs to suggest viewing gui_config.json or environment variables instead of searching Docker logs.

2. Rust Warning Cleanups

Addressed numerous compiler warnings to improve code health and build output readability:

  • Unused Imports & Dead Code: Removed unused imports (e.g., in cloudflared.rs, config.rs, user_token_db.rs, retry.rs) and tagged unused helper functions with #[allow(dead_code)] (e.g., in security_db.rs, scheduler.rs, version.rs, crypto.rs, http.rs).
  • Unused Variables: Prefixed unused variables with an underscore (e.g., _sid, _rx, _tx, _result, _entry, _timeout_secs) across mapping and token management modules.
  • OS-Specific Scoping: Scoped Windows-specific code blocks using #![cfg(target_os = "windows")] in src-tauri/src/utils/command.rs and localized process dependencies in src-tauri/src/modules/integration.rs.

3. Frontend & UX Optimizations

  • Parallel Fetching: Optimized switchAccount in src/stores/useAccountStore.ts to retrieve the current account and all accounts in parallel (Promise.all), reducing load times.
  • Non-Blocking Quota Refresh: Implemented a background quota refresh after switching accounts, avoiding unnecessary UI blocking loaders.
  • Vite Build Warning Silence: Raised the Vite chunk size warning limit to 1500kB in vite.config.ts to clean up compilation build warnings.

4. Locales & Encoding Fixes

  • UTF-8 Restored: Restored UTF-8 encoding across multiple localization files under src/locales/ (including zh.json, zh-TW.json, en.json, and others) to fix TypeScript compilation string literal syntax errors (TS1002).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant