Skip to content

Groupings visibility#50

Merged
bluetom merged 18 commits into
mainfrom
groupings-visibility
Jun 17, 2026
Merged

Groupings visibility#50
bluetom merged 18 commits into
mainfrom
groupings-visibility

Conversation

@lenaherf

@lenaherf lenaherf commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

  • added controls for the groupings, so teachers can show or hide all groups that belong to one grouping with one click
  • there are now show/hide icons next to the groupings
  • Groups that are part of multiple groupings are handled correctly
  • Users get clear messages after showing or hiding a grouping just like with "hide/show all"

Tests

  • Added tests to check that showing and hiding groupings works as expected
  • Added tests for overlapping groupings, where the same group belongs to more than one grouping

📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

  • Related to #25

🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.


@lenaherf lenaherf marked this pull request as ready for review June 17, 2026 13:24
@bluetom bluetom merged commit ef72d78 into main Jun 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants