mod_collabora: Fix HTML iframe tag to allow clipboard read / write in Chrome#57
Open
diegxalv wants to merge 1 commit into
Open
mod_collabora: Fix HTML iframe tag to allow clipboard read / write in Chrome#57diegxalv wants to merge 1 commit into
diegxalv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to issue #55.
Summary: with Edge and Chrome browsers (Firefox works correctly), the copy and paste option within the document does not work. Neither Ctrl+C nor Ctrl+V work, nor does the right-click copy and paste option.
Solution: according to Collabora’s documentation about integrations (https://sdk.collaboraonline.com/docs/advanced_integration.html#allow-the-clipboard-permission-query), the HTML
<iframe>tag in Chrome needs to contain the following element:<iframe allow="clipboard-read *; clipboard-write *"/>So we modified the
<iframe>tag in the file/templates/iframe.mustache(line 32), we added that element and the issue was resolved. Now we can copy and paste with the keyboard or using the buttons in Collabora without any problem in Chrome.Thanks.