[OU-ADD] l10n_us: preserve aba_routing#22
Draft
dnplkndll wants to merge 1 commit into
Draft
Conversation
dnplkndll
changed the title
rename_columns moves res_partner_bank.aba_routing (DEL in 19.0) to openupgrade_legacy_19_0_aba_routing so the operator's bank-routing values survive for database_cleanup. l10n_us_bank_account_type (NEW required, default 'checking') is handled by Odoo's update_db.
dnplkndll
force-pushed
the
19.0-mig-l10n_us-pre-migration
branch
from
b974e40 to
cf870b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft fork PR — for internal review before upstreaming to OCA/OpenUpgrade.
The 19.0
l10n_usmanifest dropsres.partner.bank.aba_routing(perupgrade_analysis.txt) and adds the requiredl10n_us_bank_account_typeselection. Without a pre-migration script, Odoo'supdate_dbdrops theaba_routingcolumn on install and the routing-number values are lost.What this PR does
aba_routing→openupgrade_legacy_19_0_aba_routingin pre-migration so the data survives. This is the standard OpenUpgrade preservation pattern —database_cleanuplater prompts the operator to inspect or drop the legacy column on their schedule.upgrade_analysis_work.txtfor both the DEL line and the NEW required selection (Odoo'supdate_dbhandles the default'checking'for existing rows).DonesoTest OpenUpgrade migrationincludesl10n_usinMODULES_NEW.Verification
End-to-end migrate on the openupgrade-lab against the clean 18.0 prod seed: 179/179 modules loaded (iter 8 with this + companion l10n_in fix on the integration branch).