[OU-ADD] l10n_tr_nilvera: convert environment selection to use_test_env boolean#32
Closed
dnplkndll wants to merge 1 commit into
Closed
[OU-ADD] l10n_tr_nilvera: convert environment selection to use_test_env boolean#32dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
added a commit
that referenced
this pull request
May 26, 2026
Track A batch of 5 l10n_* modules complete: - l10n_in_edi, l10n_ph (annotation-only) - PRs #30, #31 - l10n_tr_nilvera (selection -> boolean) - PR #32 - l10n_sa_edi (rename_fields + preserve) - PR #33 - l10n_it_edi (rename_xmlids for ndd consolidation) - PR #34 Deferred: - l10n_in_ewaybill (model move + 30+ xmlid moves, needs apriori coordination) - l10n_it sibling fix to PR #34 (l10n_it_edi_withholding -> l10n_it rename + broader tax-report refactor)
dnplkndll
changed the title
…nv boolean
rename_columns preserves the 18.0 res.company.l10n_tr_nilvera_environment
selection ('production'/'sandbox') as openupgrade_legacy_19_0_*.
add_fields creates the new boolean l10n_tr_nilvera_use_test_env.
map_values maps 'sandbox' -> True, 'production' -> False; NULL rows
keep the manifest default (False).
dnplkndll
force-pushed
the
19.0-mig-l10n_tr_nilvera-pre-migration
branch
from
467f336 to
6b7f4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic conversion: the 18.0 res.company selection
l10n_tr_nilvera_environment('production'/'sandbox') is replaced in 19.0 by the booleanl10n_tr_nilvera_use_test_env. Without a pre-migration the data is lost.Steps in pre-migration.py:
rename_columnspreserves the 18.0 selection column asopenupgrade_legacy_19_0_l10n_tr_nilvera_environmentadd_fieldscreates the new boolean with manifest default (False)map_valuesmaps 'sandbox' → True, 'production' → False; NULL rows take the defaultFollows the precedent in
hr_holidays/19.0.1.6/pre-migration.py(yes/no → boolean pattern).Draft fork PR — for review before upstreaming to OCA/OpenUpgrade.