[MIG] docsource: mark modules with no DB layout changes as Nothing to do#43
Closed
dnplkndll wants to merge 2 commits into
Closed
[MIG] docsource: mark modules with no DB layout changes as Nothing to do#43dnplkndll wants to merge 2 commits into
dnplkndll wants to merge 2 commits into
Conversation
126 rows where col-3 already declares ``No DB layout changes.`` get col-2 flipped from blank to ``Nothing to do``. Original col-3 notes preserved. Test-migration CI ``grep "Done\|Partial\|Nothing"`` on docsource col-2 now picks up these modules in ``MODULES_NEW`` — previously they were silently excluded from the migration smoke test, even though the analysis bot confirmed they have no DB layout delta. No script files added; no behavioural change. Pure docsource shift.
dnplkndll
force-pushed
the
19.0-mig-nothing-to-do-bulk
branch
from
3cc119e to
e368dfa
Compare
The post-migration reset runs too late when loyalty itself is force-updated
(as happens once sale_loyalty/pos_loyalty/sale_loyalty_delivery enter
$MODULES_NEW): the load-time template-syntax check renders the stale
'{{ object._get_mail_partner().lang }}' expression and raises AttributeError
at loyalty/data/mail_template_data.xml, aborting before post-migration.
Null the lang field in pre-migration so the data reload validates cleanly.
post-migration.py keeps its ORM-level reset for the non-update path.
Author
|
Superseded by the dependency-screened coverage-batch approach: #45 (19.0-mig-coverage-det-nothing, 140 no-DB-change modules) reborn cleaner from this branch's intent, with the loyalty + google-auth-dep pitfalls already handled. Closing to avoid a stale red mega-branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
126 rows in `docsource/modules180-190.rst` where col-3 already declares `No DB layout changes.` get col-2 flipped from blank → `Nothing to do`. Original col-3 notes preserved exactly.
Why
`test-migration.yml` builds `MODULES_NEW` via `grep "Done\|Partial\|Nothing"` against docsource col-2. Modules with a blank col-2 are silently excluded from the migration smoke test, even when col-3 explicitly says no DB layout changes — so the analysis bot confirmed they're trivial, but CI never exercises them.
Before:
After this PR:
Every flipped row already declared `No DB layout changes.` in col-3 — this PR only catches up the col-2 status to that declaration.
Sample diff
```
-| account_edi | |No DB layout changes. |
+| account_edi |Nothing to do |No DB layout changes. |
```
Verifier
`.claude/skills/openupgrade-contribute/scripts/verify-pr-staged.py`: 0 MISS, 0 WARN, 0 MAYBE-MISS (since this is docsource-only, no family-scope siblings to consider). Pre-commit clean.
Risk
Split if preferred
I bundled all 126 in one PR because each row is identical-shape and pedrobaeza's "one PR per module" guidance is for substantive code work, not pure docsource trivia. Happy to split by family (l10n_* / pos_* / payment_* / account_* / etc.) if reviewers prefer; each split would be a 1-line trivial PR.
Scope
Draft, fork-only first per the 2026-05-15 fork-only pivot. CI coverage gain is the main motivation — if this PR + the equivalent on OCA upstream both green-light, this catches a substantial blind spot in the migration smoke test.