Skip to content

[19.0][MIG] l10n_in_ewaybill: model move from stock + account.move ewaybill data #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnplkndll wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[19.0][MIG] l10n_in_ewaybill: model move from stock + account.move ewaybill data #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docsource/modules180-190.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ Module coverage 18.0 -> 19.0
+---------------------------------------------------+----------------------+-------------------------------------------------+
| |del| l10n_in_edi_ewaybill | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| |new| l10n_in_ewaybill | | |
| |new| l10n_in_ewaybill | Done | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| |new| l10n_in_ewaybill_irn | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
Expand Down
70 changes: 70 additions & 0 deletions openupgrade_scripts/scripts/l10n_in_ewaybill/19.0.2.0/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
from openupgradelib import openupgrade

# Companion to pre-migration.py: the 18.0 account.move ewaybill transport
# fields (preserved as openupgrade_legacy_19_0_* columns) become one
# l10n.in.ewaybill row per move in 19.0, linked via account_move_id. Rows
# enter state='pending' (the 19.0 default) -- 18.0 tracked only transport
# details on the move, never an e-Waybill number, so nothing was generated.
# company_id is a stored computed field (compute from account_move_id); set
# it explicitly from the move so the row isn't left NULL until a recompute.


@openupgrade.migrate()
def migrate(env, version):
legacy_distance = openupgrade.get_legacy_name("l10n_in_distance")
env.cr.execute(
"""
SELECT column_name FROM information_schema.columns
WHERE table_name = 'account_move' AND column_name = %s
""",
(legacy_distance,),
)
if not env.cr.fetchone():
return

legacy = {
new_name: openupgrade.get_legacy_name(old_name)
for new_name, old_name in (
("distance", "l10n_in_distance"),
("mode", "l10n_in_mode"),
("transportation_doc_date", "l10n_in_transportation_doc_date"),
("transportation_doc_no", "l10n_in_transportation_doc_no"),
("transporter_id", "l10n_in_transporter_id"),
("type_id", "l10n_in_type_id"),
("vehicle_no", "l10n_in_vehicle_no"),
("vehicle_type", "l10n_in_vehicle_type"),
)
}
any_nonnull = " OR ".join(f"am.{c} IS NOT NULL" for c in legacy.values())

openupgrade.logged_query(
env.cr,
f"""
INSERT INTO l10n_in_ewaybill (
account_move_id, company_id, state,
distance, mode,
transportation_doc_date, transportation_doc_no,
transporter_id, type_id,
vehicle_no, vehicle_type,
create_uid, create_date, write_uid, write_date
)
SELECT
am.id,
am.company_id,
'pending'::varchar,
am.{legacy["distance"]},
CASE WHEN am.{legacy["mode"]} = '0' THEN NULL ELSE am.{legacy["mode"]} END,
am.{legacy["transportation_doc_date"]},
am.{legacy["transportation_doc_no"]},
am.{legacy["transporter_id"]},
am.{legacy["type_id"]},
am.{legacy["vehicle_no"]},
am.{legacy["vehicle_type"]},
COALESCE(am.write_uid, am.create_uid, 1),
COALESCE(am.write_date, am.create_date, NOW() AT TIME ZONE 'UTC'),
COALESCE(am.write_uid, am.create_uid, 1),
COALESCE(am.write_date, am.create_date, NOW() AT TIME ZONE 'UTC')
FROM account_move am
WHERE {any_nonnull}
""",
)
104 changes: 104 additions & 0 deletions openupgrade_scripts/scripts/l10n_in_ewaybill/19.0.2.0/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
from openupgradelib import openupgrade

# l10n_in_ewaybill 19.0 converges several changes (see PR body for detail):
# the l10n.in.ewaybill[.cancel] models move out of l10n_in_ewaybill_stock,
# six xmlids move with them, three res.company credential columns drop their
# `_edi_` segment, and eight account.move ewaybill columns are preserved as
# legacy for post-migration.py to spawn l10n.in.ewaybill rows. The
# l10n_in_edi_ewaybill -> l10n_in_ewaybill module rename is already handled by
# apriori (update_module_names in base pre-migration), so it needs no work here.

_renamed_xmlids_from_stock = [
(
"l10n_in_ewaybill_stock.l10n_in_ewaybill_form_action",
"l10n_in_ewaybill.l10n_in_ewaybill_form_action",
),
(
"l10n_in_ewaybill_stock.action_report_ewaybill",
"l10n_in_ewaybill.action_report_ewaybill",
),
(
"l10n_in_ewaybill_stock.access_l10n_in_ewaybill",
"l10n_in_ewaybill.access_l10n_in_ewaybill",
),
(
"l10n_in_ewaybill_stock.access_l10n_in_ewaybill_cancel",
"l10n_in_ewaybill.access_l10n_in_ewaybill_cancel",
),
(
"l10n_in_ewaybill_stock.l10n_in_ewaybill_comp_rule",
"l10n_in_ewaybill.l10n_in_ewaybill_comp_rule",
),
(
"l10n_in_ewaybill_stock.paperformat_ewaybill",
"l10n_in_ewaybill.paperformat_ewaybill",
),
]

_preserved_columns_account_move = {
# 18.0 columns owned by l10n_in_edi_ewaybill; DEL in 19.0. We preserve
# them as openupgrade_legacy_19_0_* so post-migration.py can spawn
# l10n.in.ewaybill rows from them.
"account_move": [
("l10n_in_distance", None),
("l10n_in_mode", None),
("l10n_in_transportation_doc_date", None),
("l10n_in_transportation_doc_no", None),
("l10n_in_transporter_id", None),
("l10n_in_type_id", None),
("l10n_in_vehicle_no", None),
("l10n_in_vehicle_type", None),
],
}

_renamed_fields_company_credentials = [
(
"res.company",
"res_company",
"l10n_in_edi_ewaybill_auth_validity",
"l10n_in_ewaybill_auth_validity",
),
(
"res.company",
"res_company",
"l10n_in_edi_ewaybill_password",
"l10n_in_ewaybill_password",
),
(
"res.company",
"res_company",
"l10n_in_edi_ewaybill_username",
"l10n_in_ewaybill_username",
),
]


@openupgrade.migrate()
def migrate(env, version):
# Move the model ownership: ir.model + ir.model.fields rows that point
# at l10n.in.ewaybill / l10n.in.ewaybill.cancel get their `module`
# column rewritten from l10n_in_ewaybill_stock to l10n_in_ewaybill.
# The SQL table itself is not renamed (the table name is identical).
openupgrade.update_module_moved_models(
env.cr, "l10n.in.ewaybill", "l10n_in_ewaybill_stock", "l10n_in_ewaybill"
)
openupgrade.update_module_moved_models(
env.cr, "l10n.in.ewaybill.cancel", "l10n_in_ewaybill_stock", "l10n_in_ewaybill"
)

# Six XML records (action, report, two access rules, rule, paperformat)
# ship under l10n_in_ewaybill in 19.0 but lived under
# l10n_in_ewaybill_stock in 18.0. Rename so customer references to
# them survive the upgrade.
openupgrade.rename_xmlids(env.cr, _renamed_xmlids_from_stock)

# Three res.company credential columns drop the `_edi_` segment.
# apriori's update_module_names already moved the ir_model_fields
# ownership; rename_fields handles the SQL column rename + filter /
# export / translation side effects.
openupgrade.rename_fields(env, _renamed_fields_company_credentials)

# Preserve the 8 account.move ewaybill columns before Odoo's update_db
# drops them. post-migration.py consumes the legacy values to spawn
# l10n.in.ewaybill rows.
openupgrade.rename_columns(env.cr, _preserved_columns_account_move)
Loading
Loading