Skip to content

Don't ignore unrecognized CAA parameters #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aarongable wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't ignore unrecognized CAA parameters #8620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions va/caa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,16 @@ func (va *ValidationAuthorityImpl) validateCAA(caaSet *caaResult, wildcard bool,
continue
}

for _, param := range parsedParams {
// The existence of any parameters other than the ones we recognize means
// that this user wants something we don't understand. Don't interpret
// this record as allowing issuance. We're case-sensitive here to be
// strict in what we accept.
if param.tag != "accounturi" && param.tag != "validationmethods" {
continue
}
}

if !caaAccountURIMatches(parsedParams, va.accountURIPrefixes, params.accountURIID) {
continue
}
Expand Down