Replace docker/login-action with inline docker login#8694
Open
Replace docker/login-action with inline docker login#8694
Conversation
Drop dependency on docker/login-action by replacing it with a simple docker login command. Just reduces our supply chain exposure a bit. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
inahga
commented
Mar 30, 2026
| # Password or personal access token used to log against the Docker registry | ||
| password: ${{ secrets.DOCKER_PASSWORD}} | ||
| # Log out from the Docker registry at the end of a job | ||
| logout: true |
Contributor
Author
There was a problem hiding this comment.
We lose logout at the end of the job, but I think this is moot. The runner is discarded after each matrix run.
aarongable
requested changes
Apr 2, 2026
.github/workflows/boulder-ci.yml
Outdated
Comment on lines
+78
to
+81
| - name: Login to GitHub Container Registry | ||
| run: printenv GITHUB_TOKEN | docker login -u "$GITHUB_ACTOR" --password-stdin ghcr.io | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
This is incorrect -- we're not logging into ghcr.io here, and we can't use GITHUB_TOKEN to authenticate. We're logging in to dockerhub itself, so that we don't get hit by ratelimits when downloading the boulder_tools image.
jsha
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop dependency on docker/login-action by replacing it with a simple
docker login command. Just reduces our supply chain exposure a bit.