Conversation
aarongable
reviewed
Apr 8, 2026
va/va.go
Outdated
Comment on lines
+344
to
+345
| b, _ := json.Marshal(logArgs) | ||
| fmt.Println("oh no", string(b)) |
Contributor
There was a problem hiding this comment.
Remove debugging print
Suggested change
| b, _ := json.Marshal(logArgs) | |
| fmt.Println("oh no", string(b)) |
va/va_test.go
Outdated
| name string | ||
| primaryDNS bdns.Client | ||
| experimentalDNS bdns.Client | ||
| domain string |
Contributor
There was a problem hiding this comment.
You've deleted domain from all three test cases below.
va/va_test.go
Outdated
Comment on lines
+473
to
+477
| matchingLogs := mockLog.GetAllMatching(tc.expectLog) | ||
| if len(matchingLogs) != 1 { | ||
| t.Errorf("Expected log line matching %q, got: %s", | ||
| tc.expectLog, strings.Join(mockLog.GetAll(), "\n")) | ||
| } |
Contributor
There was a problem hiding this comment.
We have shorthand for this: mocklog.ExpectMatch().
aarongable
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go's JSON marshaling encodes
[]bytein base64. Previously, experiment results were logging*vapb.ValidationResult, which containedrepeated corepb.ValidationRecord. In turn,corepb.ValidationRecordcontains three[]bytefields:By contrast,
core.ValidationRecord(a non-protobuf struct), has fields of typenetip.Addr:Those get serialized like
127.0.01, which is what we want.This PR reworks the
runExperimentfunction so that instead of receivingremoteResult(which could contain*vapb.IsCAAValidResponseor*vapb.ValidationResult), it receives a problem and an (optional)core.ValidationRecord. This allows us to more straightforwardly log things without running into base64-encoding problems.To test this I modified
TestExperimentalVAConcurrenceto use HTTP-01 validation, since the affected log fields don't show up under DNS-01 validation. I also tweakedipFakeDNSto allow customizing the IP address it returns.Fixes #8701