Conversation
Mirrors dataset-level TopCommits per developer: largest individual commits by lines changed, capped at 10 with a hidden counter. Shown in the CLI profile output and the standalone --email HTML profile page; intentionally not surfaced on the main report's Developer Profiles cards to keep those compact. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds the Top commits row to the Profile table (ranking key, tiebreak, message truncation, render surfaces, and the IsZero divergence from the dataset-level Top Commits section), a README bullet alongside Top files, and includes TopCommits in the deterministic-tiebreak note on per-profile sub-lists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirrors the "X of Y" pattern already used on Top Contributors, Hotspots, Directories, and other top-N sections so a reader can tell at a glance that the cards below are a truncated slice of a larger dev set rather than the full roster. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e611f7a3ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Both new Top-commits surfaces sliced SHA to a fixed 12 chars
(`tc.SHA[:12]` in the CLI formatter, `{{slice .SHA 0 12}}` in the HTML
profile template), which panics / errors when a dataset carries short
commit IDs — LoadJSONL performs no length validation, so hand-built
fixtures like "c1" or any future ingest path that emits abbreviated
SHAs would crash profile text output or break template execution.
CLI clamps via `if len(sha) > 12` before slicing; HTML uses
`printf "%.12s"` which truncates safely on any length. The other
SHA slice sites in format.go (TopCommits / LatestCommits) share the
same latent risk and are left untouched to keep this change scoped.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
profile_template.go: the per-dev Top Commits block now drops the
Message column (header, cells, and hidden-row colspan) when the first
commit carries an empty message — mirrors the dataset-level Top
Commits convention so `extract --include-commit-messages` is a strict
opt-in instead of leaving an always-empty column in place.
template.go: the dataset-level Top Commits row switched from
{{slice .SHA 0 12}} to {{printf "%.12s" .SHA}}, closing the same
latent crash path the profile block was already patched for.
Added a report-level regression covering both invariants on the
profile template: short SHAs render intact, the 16-char SHA clamps
to 12, and the Message column is absent when no TopCommit has a
message.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.