tests/nim: split NIM e2e tests into a dedicated suite - #1212
Open
eriknordmark wants to merge 1 commit into
Open
Conversation
Carves the nim_*.txt testdata files out of tests/network/ into a new tests/nim/ suite so coverage attributable to the NIM-focused tests is reported independently of the broader network suite. The suite mirrors the nodeagent and baseosmgr templates: a Makefile, eden-config.yml pointing at the test scenario, and eden.nim.tests.txt listing the nine moved scripts. The escript runner (eden.escript.test) handles them as TestEdenScripts/<name> without needing a per-suite Go entrypoint, matching how nodeagent and baseosmgr run. The LPS and radio-silence NIM tests under tests/eclient/testdata/ stay in the eclient suite because they depend on the eclient app and local-manager harness; they are NIM tests by exercise but not by runtime dependency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: eriknordmark <erik@zededa.com>
eriknordmark
force-pushed
the
nim-suite-split
branch
from
July 11, 2026 07:10
70e0165 to
b4af4d4
Compare
eriknordmark
marked this pull request as ready for review
July 20, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / WIP.
Splits the NIM end-to-end tests into a dedicated
tests/nim/suite:moves the nine
nim_*.txttestdata scripts out oftests/network/testdata/intotests/nim/testdata/, with a matchingMakefile,
eden-config.yml, andeden.nim.tests.txt, so NIM-focusedcoverage is reported independently of the broader network suite. The
escript runner handles them as
TestEdenScripts/<name>, mirroring thenodeagent and baseosmgr suites.
The LPS and radio-silence NIM tests under
tests/eclient/testdata/stay in the eclient suite — they depend on the eclient app and
local-manager harness, so they are NIM tests by exercise but not by
runtime dependency.