Skip to content

Potential fix for code scanning alert no. 2388: Use of insecure HostKeyCallback implementation #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eriknordmark wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Draft

Potential fix for code scanning alert no. 2388: Use of insecure HostKeyCallback implementation #6249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion evetest/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/lf-edge/eve/evetest/utils"
"github.com/lf-edge/eve/pkg/pillar/utils/generics"
"golang.org/x/crypto/ssh"
"golang.org/x/crypto/ssh/knownhosts"
)

type watchdogWriter struct {
Expand Down Expand Up @@ -61,8 +62,13 @@ func (th *TestHarness) runScriptOverSSH(ctx context.Context,
addr string, auth AuthMethod, script string,
stdout, stderr io.Writer, stdoutWatchdogTimeout time.Duration) error {

hostKeyCallback, err := knownhosts.New("/root/.ssh/known_hosts")
if err != nil {
return fmt.Errorf("failed to initialize SSH known_hosts callback: %w", err)
}

sshConfig := &ssh.ClientConfig{
HostKeyCallback: ssh.InsecureIgnoreHostKey(),
HostKeyCallback: hostKeyCallback,
Timeout: 5 * time.Second,
}

Expand Down
Loading