Potential fix for code scanning alert no. 2389: Arbitrary file access during archive extraction ("Zip Slip") - #6250
Draft
eriknordmark wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 2389: Arbitrary file access during archive extraction ("Zip Slip")#6250eriknordmark wants to merge 1 commit into
eriknordmark wants to merge 1 commit into
Conversation
… during archive extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| safePath := func(oldPath string) (string, error) { | ||
| if oldPath == "" { | ||
| return "", fmt.Errorf("empty archive path") | ||
| } |
| if err != nil { | ||
| return fmt.Errorf("ExtractFromTar: Next() failed: %w", err) | ||
| } | ||
| entryPath, err := safePath(header.Name) |
| } | ||
| } | ||
| if err := os.Symlink(pathBuilder(header.Linkname), pathBuilder(header.Name)); err != nil { | ||
| linkPath, err := safePath(header.Linkname) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/lf-edge/eve/security/code-scanning/2389
To fix Zip Slip safely without changing intended behavior, validate every archive entry path before any filesystem operation. Build a helper that:
path.Clean)...and/..prefixes/components).destination+/(or equals destination).Then replace all
pathBuilder(header.Name)calls with this validated path (computed once per header). For symlinks, also validateheader.Linknamesimilarly before creating the symlink target path, so link targets cannot escape destination either.Edits are confined to
evetest/utils/tar.go: add one import (strings), add a safe-path helper closure inExtractFromTar, compute validatedentryPathper header, and use it in all file operations.Suggested fixes powered by Copilot Autofix. Review carefully before merging.