Skip to content

Fix linux/debug test breaks. #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Apr 30, 2026
Merged

Fix linux/debug test breaks. #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions test/messages/http_body_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,33 +95,35 @@ BOOST_AUTO_TEST_CASE(http_body_reader__init__application_octet_stream__construct
BOOST_REQUIRE(std::holds_alternative<data_reader>(reader.reader_));
}

BOOST_AUTO_TEST_CASE(http_body_reader__init__application_octet_stream_with_attachment__constructs_file_reader)
{
message_header<true, fields> header{};
header.set(http::field::content_type, "application/octet-stream");
header.set(http::field::content_disposition, "filename=somenonsense.jpg");
body::value_type value{};
value = file_body::value_type{};
accessor reader(header, value);
length_type length{ max_size_t };
boost_code ec{};
reader.init(length, ec);
BOOST_REQUIRE(std::holds_alternative<file_reader>(reader.reader_));
}
// TODO: linux debug boost asserts on body_.file_.is_open().
////BOOST_AUTO_TEST_CASE(http_body_reader__init__application_octet_stream_with_attachment__constructs_file_reader)
////{
//// message_header<true, fields> header{};
//// header.set(http::field::content_type, "application/octet-stream");
//// header.set(http::field::content_disposition, "filename=somenonsense.jpg");
//// body::value_type value{};
//// value = file_body::value_type{};
//// accessor reader(header, value);
//// length_type length{ max_size_t };
//// boost_code ec{};
//// reader.init(length, ec);
//// BOOST_REQUIRE(std::holds_alternative<file_reader>(reader.reader_));
////}

BOOST_AUTO_TEST_CASE(http_body_reader__init__application_octet_stream_with_dirty_attachment__constructs_file_reader)
{
message_header<true, fields> header{};
header.set(http::field::content_type, "application/octet-stream");
header.set(http::field::content_disposition, "dirty 42; filename* = somenonsense.jpg; some other nonsense");
body::value_type value{};
value = file_body::value_type{};
accessor reader(header, value);
length_type length{ max_size_t };
boost_code ec{};
reader.init(length, ec);
BOOST_REQUIRE(std::holds_alternative<file_reader>(reader.reader_));
}
// TODO: linux debug boost asserts on body_.file_.is_open().
////BOOST_AUTO_TEST_CASE(http_body_reader__init__application_octet_stream_with_dirty_attachment__constructs_file_reader)
////{
//// message_header<true, fields> header{};
//// header.set(http::field::content_type, "application/octet-stream");
//// header.set(http::field::content_disposition, "dirty 42; filename* = somenonsense.jpg; some other nonsense");
//// body::value_type value{};
//// value = file_body::value_type{};
//// accessor reader(header, value);
//// length_type length{ max_size_t };
//// boost_code ec{};
//// reader.init(length, ec);
//// BOOST_REQUIRE(std::holds_alternative<file_reader>(reader.reader_));
////}

BOOST_AUTO_TEST_CASE(http_body_reader__init__text_plain__constructs_string_reader)
{
Expand Down