Move Argument code from Variable to Argument#236
Merged
avalentino merged 1 commit intoliberfa:mainfrom Apr 29, 2026
Merged
Conversation
`Variable` is the base class of `Argument`, `StatusCode` and `Return`, but most of the code it has so far contained has only been needed by `Argument`. Now `Variable` only implements code that is used by all of its subclasses, which simplifies not only it but also `StatusCode` and `Return`.
avalentino
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variableis the base class ofArgument,StatusCodeandReturn, but most of the code it contains is only needed byArgument. With this PRVariableonly implements code that is used by all of its subclasses, which simplifies not only it but alsoStatusCodeandReturn.