fix(chocolatey): address 0.9.59 moderation guidelines in the nuspec template#208
Merged
Conversation
…emplate The 0.9.59 automated validation passed with no Requirements; two Guidelines remain for next releases: the loopback URL in the description is now plain 'localhost:3000' (a scheme-prefixed 127.0.0.1 URL is flagged as potentially invalid), and projectUrl now points at the product page (https://libredb.org) so it no longer duplicates projectSourceUrl (CPMR0041). The owners==authors note needs no change - the maintainer is the software author.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Chocolatey .nuspec template to align with Chocolatey moderation guidelines, ensuring future releases avoid guideline-level flags while keeping the packaging pipeline unchanged (template-only adjustment).
Changes:
- Set
projectUrlto the product page (https://libredb.org) while keepingprojectSourceUrlon GitHub to avoid duplicate-URL guideline flag (CPMR0041). - Replace the loopback usage link
http://127.0.0.1:3000with plain, code-formattedlocalhost:3000to avoid “unresolvable URL” guideline warnings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Chocolatey submission (0.9.59) passed automated validation with no Requirements flagged; the validator raised two Guideline-level items to fix for future releases:
http://127.0.0.1:3000, which the validator cannot resolve. Now written as plainlocalhost:3000(code-formatted, no scheme).projectUrlnow points at the product page (https://libredb.org);projectSourceUrlkeeps the GitHub repository.The remaining Note (owners matches authors) needs no change: the maintainer IS the software author - the reviewer confirms this manually, and it is the expected shape for a vendor-owned package.
No repush of 0.9.59: Guidelines do not hold up approval, and a same-version repush would restart the automated checks. These fixes ship with the next release's rendered nuspec.
Template-only change;
tests/unit/render-windows-packaging.test.tscovers the rendering.