Skip to content

Fix fseeko/ftello/strcasecmp not being defined#3

Open
nightmareci wants to merge 1 commit into
libsdl-org:5.9.0-SDLfrom
nightmareci:5.9.0-SDL
Open

Fix fseeko/ftello/strcasecmp not being defined#3
nightmareci wants to merge 1 commit into
libsdl-org:5.9.0-SDLfrom
nightmareci:5.9.0-SDL

Conversation

@nightmareci

Copy link
Copy Markdown

Fixes building vendored SDL Mixer for me on Linux with wavpack enabled.

@madebr madebr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this @sezero ?
I don't like how it handles _POSIX_C_SOURCE.

I also think this should be upstreamed. The project is very welcoming to external contributions.

@sezero

sezero commented May 31, 2026

Copy link
Copy Markdown

I don't like how it handles _POSIX_C_SOURCE.

Neither do I.

What I don't understand is: wavpack builds just fine on linux by itself. Are compiler extensions disabled when wavpack is built under SDL_mixer?? I don't think so....

I also think this should be upstreamed. The project is very welcoming to external contributions.

I agree. We should see what upstream thinks.

@sezero

sezero commented May 31, 2026

Copy link
Copy Markdown

What I don't understand is: wavpack builds just fine on linux by itself. Are compiler extensions disabled when wavpack is built under SDL_mixer?? I don't think so....

Maybe add an explicit set(CMAKE_C_EXTENSIONS ON) in wavpack cmake'ry ???

@madebr

madebr commented May 31, 2026

Copy link
Copy Markdown

Maybe add an explicit set(CMAKE_C_EXTENSIONS ON) in wavpack cmake'ry ???

If that does it, then prefer to do set_property(TARGET wavpack PROPERTY C_EXTENSIONS ON) instead.

@sezero

sezero commented May 31, 2026

Copy link
Copy Markdown

Maybe add an explicit set(CMAKE_C_EXTENSIONS ON) in wavpack cmake'ry ???

If that does it, then prefer to do set_property(TARGET wavpack PROPERTY C_EXTENSIONS ON) instead.

That would do too, I guess, provided that cli wavpack programs aren't affected by the issue.
(The If that does it still has emphasis though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants