You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What I don't understand is: wavpack builds just fine on linux by itself. Are compiler extensions disabled when wavpack is built under SDL_mixer?? I don't think so....
I also think this should be upstreamed. The project is very welcoming to external contributions.
What I don't understand is: wavpack builds just fine on linux by itself. Are compiler extensions disabled when wavpack is built under SDL_mixer?? I don't think so....
Maybe add an explicit set(CMAKE_C_EXTENSIONS ON) in wavpack cmake'ry ???
Maybe add an explicit set(CMAKE_C_EXTENSIONS ON) in wavpack cmake'ry ???
If that does it, then prefer to do set_property(TARGET wavpack PROPERTY C_EXTENSIONS ON) instead.
That would do too, I guess, provided that cli wavpack programs aren't affected by the issue.
(The If that does it still has emphasis though.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes building vendored SDL Mixer for me on Linux with wavpack enabled.