Skip to content

correctly scale external input #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drfiemost wants to merge 1 commit into from
+4 −4
Closed

correctly scale external input #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class Filter
*
* @param input a signed 16 bit sample
*/
void input(int16_t input) { Ve = fmc.getNormalizedVoice(input/32768.f, 0); }
void input(int16_t input) { Ve = fmc.getNormalizedVoice(input/65536.f, 0); }

void restart() { restartIntegrators(); Vhp = 0; Vlp = 0; Vbp = 0; }
};
Expand Down
6 changes: 3 additions & 3 deletions src/Voice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ class Voice

EnvelopeGenerator envelopeGenerator;

/// The DAC LUT for analog waveform output
/// The DAC LUT for analog waveform output, range [-0.5,0.5]
float* wavDAC; //-V730_NOINIT this is initialized in the SID constructor

/// The DAC LUT for analog envelope output
/// The DAC LUT for analog envelope output, range [0,1]
float* envDAC; //-V730_NOINIT this is initialized in the SID constructor

public:
Expand All @@ -61,7 +61,7 @@ class Voice
*
* Ideal range [-2048*255, 2047*255].
*
* @return the voice analog output
* @return the voice analog output, range [-0.5,0.5]
*/
RESIDFP_INLINE
float output()
Expand Down
Loading