Skip to content

Introduce Redeems Buffer #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rkolpakov wants to merge 4 commits into
base: develop
Choose a base branch
from

refactor: move redeems buffer ownership to lido

398c5b4
Select commit
Loading
Failed to load commit list.
Draft

Introduce Redeems Buffer #1767

refactor: move redeems buffer ownership to lido
398c5b4
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed Apr 30, 2026 in 4s

7 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 6 medium

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 228 in contracts/0.8.25/RedeemsBuffer.sol

See this annotation in the file changed.

Code scanning / Slither

Functions that send Ether to arbitrary destinations High

RedeemsBuffer.recoverEther(address) sends eth to arbitrary user
Dangerous calls:
- (success,None) = _recipient.call{value: amount}()

Check warning on line 90 in contracts/0.8.25/RedeemsBuffer.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

RedeemsBuffer.initialize(address) ignores return value by LIDO.approve(address(BURNER),type()(uint256).max)

Check warning on line 125 in contracts/0.8.25/RedeemsBuffer.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

RedeemsBuffer.redeem(uint256,address) ignores return value by LIDO.transferSharesFrom(msg.sender,address(this),sharesAmount)

Check warning on line 217 in contracts/0.8.25/RedeemsBuffer.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

RedeemsBuffer.recoverStETHShares(address) ignores return value by LIDO.transferShares(_recipient,shares)

Check warning on line 255 in contracts/0.8.25/RedeemsBuffer.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

RedeemsBuffer._currentRefSlot() ignores return value by (refSlot,None) = HASH_CONSENSUS.getCurrentFrame()

Check warning on line 178 in contracts/0.8.9/Accounting.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

Accounting._getRedeemed(Accounting.Contracts,bool) ignores return value by _contracts.redeemsBuffer.getRedeemed()

Check warning on line 178 in contracts/0.8.9/Accounting.sol

See this annotation in the file changed.

Code scanning / Slither

Unused return Medium

Accounting._getRedeemed(Accounting.Contracts,bool) ignores return value by _contracts.redeemsBuffer.getRedeemedForLastRefSlot()