Skip to content

[RFC] Add BOLT 12 payer proof primitives #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenzopalazzo wants to merge 20 commits into
base: main
Choose a base branch
from

fixup! feat(offers): add BOLT 12 payer proof primitives

fc54321
Select commit
Loading
Failed to load commit list.
Open

[RFC] Add BOLT 12 payer proof primitives #4297

fixup! feat(offers): add BOLT 12 payer proof primitives
fc54321
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2026 in 0s

86.23% (-0.92%) compared to 42e198c

View this Pull Request on Codecov

86.23% (-0.92%) compared to 42e198c

Details

Codecov Report

❌ Patch coverage is 89.98121% with 160 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.23%. Comparing base (42e198c) to head (fc54321).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/offers/payer_proof.rs 86.64% 115 Missing and 28 partials ⚠️
lightning/src/offers/merkle.rs 96.85% 7 Missing and 4 partials ⚠️
lightning/src/ln/channelmanager.rs 90.62% 2 Missing and 1 partial ⚠️
lightning/src/ln/outbound_payment.rs 97.72% 1 Missing ⚠️
lightning/src/offers/invoice.rs 97.91% 1 Missing ⚠️
lightning/src/offers/signer.rs 97.29% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4297      +/-   ##
==========================================
- Coverage   87.15%   86.23%   -0.92%     
==========================================
  Files         161      157       -4     
  Lines      109251   110187     +936     
  Branches   109251   110187     +936     
==========================================
- Hits        95215    95022     -193     
- Misses      11560    12521     +961     
- Partials     2476     2644     +168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov