lnwire+chancloser: add new fee range TLV to co-op msg & use during negotiation #5644
Closed
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Closed
lnwire+chancloser: add new fee range TLV to co-op msg & use during negotiation #5644Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Roasbeef wants to merge 2 commits intolightningnetwork:masterfrom
Conversation
In this commit, we add a new FeeRange TLV to the ClosingSigned message that allows either side to attempt to cut the fee negotiation process short by sending their min+max fee. In the ideal case, the funder sends over their fee range, which is accepted by the responder. However, it's possible for things to break down which results in either the close attempting being abandoned, or they fall back to the legacy less defined negotiation process.
In this commit, we begin to use the new fee rate information as a hint to allow us to short circuit the co-op close negotiation process by simply echo'ing back the initiator's fee rate if it's within our desired range, or accepting the responder's fee rate for the initiator. This is just an initial draft, as we still need to hone into exactly what fee range we want to advertise as the initiator.
Member
Author
|
The second commit is incomplete as it needs to gate that behavior to retain the prior tests, then add new ones that exercise the new behavior. |
11 tasks
Collaborator
|
@Crypt-iQ: review reminder |
Collaborator
|
replaced by #7062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we add a new FeeRange TLV to the ClosingSigned message
that allows either side to attempt to cut the fee negotiation process
short by sending their min+max fee. In the ideal case, the funder sends
over their fee range, which is accepted by the responder. However, it's
possible for things to break down which results in either the close
attempting being abandoned, or they fall back to the legacy less defined
negotiation process.
We then begin to use the new fee rate information as a hint
to allow us to short circuit the co-op close negotiation process by
simply echo'ing back the initiator's fee rate if it's within our desired
range, or accepting the responder's fee rate for the initiator.
This is just an initial draft, as we still need to hone into exactly
what fee range we want to advertise as the initiator.
Implements a variant of lightning/bolts#847
dependent on : lightning/bolts#1016
Fixes #4413