uaf: Fix page double-free on navigate failure. - #3098
Merged
Conversation
This is a classic (for us) issue. Session.initiateRootNavigation errdefer a number of steps BUT, if the frame.navigate() call reaches libcurl's event-loop, then those errdefer can conflict with the `frameErrorCallback`. Who's responsible for cleaning up? It depends where the failure happened. So the cleanup is now more defensive. Page.destroying guards against multiple calls to Session.queuePageDestruction and initiateRootNavigation no longer assumes that the new Page is in the pages collection. I believe this is the cause of the "release overflow" for `Selection` that is infrequent but has been seen for a long time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a classic (for us) issue. Session.initiateRootNavigation errdefer a number of steps BUT, if the frame.navigate() call reaches libcurl's event-loop, then those errdefer can conflict with the
frameErrorCallback. Who's responsible for cleaning up? It depends where the failure happened.So the cleanup is now more defensive. Page.destroying guards against multiple calls to Session.queuePageDestruction and initiateRootNavigation no longer assumes that the new Page is in the pages collection.
I believe this is the cause of the "release overflow" for
Selectionthat is infrequent but has been seen for a long time.