LCORE-836: spike-finalize — strip PoC evidence, fix spec placeholder#1799
Conversation
Spike-finalize orphan check found one LCORE-???? left in the spec doc's
Test patterns section ("migrate tests/e2e/configuration/** ... as part of
LCORE-???? (test migration JIRA)"). The placeholder replacement after
filing only ran over the spike doc, not the spec doc. Point it at the
filed ticket: LCORE-2342 (Migrate in-repo e2e / integration test
configurations).
…erge commit The poc-results/ validation evidence merged to main with the docs, but the spike howto says PoC validation results are not kept on main — it should have been stripped pre-merge. Remove the whole poc-results/ dir (library-mode evidence, the unified-library config, and the Pydantic AI research report) from the tree. The spike doc still cites these artifacts (Results bundle, the vacuous-shield finding, Decision S5's research report, Appendix B repro). Rather than drop the citations, re-point them to GitHub permalinks at the PR-1580 merge commit (42844d0), where the files remain in history — so the references still resolve while main's tree stays clean. Appendix B is reframed as a historical record with the config linked at the permalink (the relative -c path no longer exists in the tree). Also folds in the spec-doc orphan-placeholder fix (LCORE-???? -> LCORE-2342) from the previous commit on this branch.
|
Warning Review limit reached
More reviews will be available in 5 minutes and 47 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Post-merge spike-finalize cleanup for LCORE-836. Docs only.
poc-results/from the tree (PoC validation results aren't kept onmainper the spike howto); the spike doc's references are re-pointed to permalinks at the PR-1580 merge commit (42844d06) so they still resolve, and Appendix B's repro fetches the config from there.LCORE-????placeholder in the spec doc → LCORE-2342.Tools used to create PR