Skip to content

fix(auth): detect HTTPS behind TLS-terminating reverse proxy #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnjoyBacon7 merged 3 commits into from
Apr 22, 2026
Merged

fix(auth): detect HTTPS behind TLS-terminating reverse proxy #331

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f88f7d
fix(auth): detect HTTPS behind TLS-terminating reverse proxy
etiquet Apr 19, 2026
06c8c0a
style: blank line after local import in _is_request_secure
EnjoyBacon7 Apr 21, 2026
0bf9f6f
fix: drop redundant local os import, parse chained X-Forwarded-Proto
EnjoyBacon7 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions openrag/routers/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,16 @@ def _require_oidc_mode():
def _is_request_secure(request: Request) -> bool:
"""True if the client-observed scheme is HTTPS.

``request.url.scheme`` already accounts for reverse-proxy headers when the
app is started with ``proxy_headers=True`` (see ``api.py``).
Checks multiple indicators:
1. ``PREFERRED_URL_SCHEME`` env var (set when behind a TLS-terminating proxy)
2. ``X-Forwarded-Proto`` header (set by reverse proxies like Traefik/Nginx)
3. ``request.url.scheme`` (accounts for proxy_headers=True in uvicorn)
"""
import os
if os.environ.get("PREFERRED_URL_SCHEME", "").lower() == "https":
return True
if request.headers.get("x-forwarded-proto", "").lower() == "https":
return True
return request.url.scheme == "https"
Comment thread
coderabbitai[bot] marked this conversation as resolved.


Expand Down
Loading