Open
Conversation
Member
|
This seems ok, I guess I wonder what happens if there are no files in |
Author
Lineman starts up as normal; no warnings printed.
After deleting my API files then doing a GET on a previously working stub, I get a "Not found" returned by Express but nothing breaks. In app.get('/api/1.0/goals', function (req, res) {
fs.readFile('config/stubs/1.0/goals.json', function(err, data) {
if (err) {
res.status(404).send('Not found');
} else {
res.header('Cache-Control', 'none').contentType('application/json').send(data);
}
res.end();
});
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At #318 it's suggested to use the
config/stubsfolder for API stub files. I think this is a good suggestion and am using this for a local project.@davemo noted at #318 (comment) that "The most annoying part of working in this way is having to restart lineman when a stubbed file changes."
This pull request solves that issue - an API file can be edited and is immediately available via Express.