Skip to content

Audit native process execution for command-stream#1865

Open
konard wants to merge 4 commits into
mainfrom
issue-1864-58f21a62b46d
Open

Audit native process execution for command-stream#1865
konard wants to merge 4 commits into
mainfrom
issue-1864-58f21a62b46d

Conversation

@konard

@konard konard commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added src/command-stream-exec.lib.mjs, a command-stream-backed adapter for legacy exec call sites that need { stdout, stderr } and nonzero-exit errors.
  • Migrated eligible native exec wrappers across GitHub merge/retry helpers, invite handling, limits, git checks, session/status probes, screen helpers, and runtime discovery.
  • Added default-suite audit coverage so new native child_process usage must either migrate to command-stream or carry a documented exception.
  • Documented the research, before/after scans, remaining exceptions, and upstream command-stream blockers in the issue Double check that we use https://github.com/link-foundation/command-stream for all CLI and TUI operations #1864 case study.

Case study: https://github.com/link-assistant/hive-mind/blob/issue-1864-58f21a62b46d/docs/case-studies/issue-1864/README.md

Reproduction and verification

  • node tests/test-issue-1864-command-stream-audit.mjs
  • node tests/test-command-stream-exec-wrapper-1864.mjs
  • node tests/github-rate-limit.test.mjs
  • node tests/test-execgh-transient-retry-1756.mjs
  • Focused migrated-area tests listed in the case study
  • npm test > ci-logs/local-npm-test.log 2>&1 - passed all 231 selected default test files
  • npm run lint > ci-logs/local-npm-lint.log 2>&1 - passed
  • npm run format:check > ci-logs/local-npm-format-check.log 2>&1 - passed

Upstream command-stream notes

Existing upstream command-stream issues cover the blockers that kept 20 native-process exceptions, including process lifecycle/kill access, signal support, spawn/execFile-style argv execution, sync execution, and known quoting/output issues. No duplicate upstream issue was filed.

Fixes #1864

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #1864
@konard konard self-assigned this Jun 8, 2026
@konard konard changed the title [WIP] Double check that we use https://github.com/link-foundation/command-stream for all CLI and TUI operations Audit native process execution for command-stream Jun 8, 2026
@konard
konard marked this pull request as ready for review June 8, 2026 11:53
@konard

konard commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Working session summary

Implemented and pushed the fix on issue-1864-58f21a62b46d.

PR #1865 is ready for review: #1865

Key changes:

Verification:

Working tree is clean.


This summary was automatically extracted from the AI working session output.

@konard

konard commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $24.000829

📊 Context and tokens usage:

  • 823.8K / 1.1M (78%) input tokens, 57.2K / 128K (45%) output tokens

Total: (823.8K + 13.2M cached) input tokens, 57.2K output tokens, $24.000829 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (70010KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard

konard commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double check that we use https://github.com/link-foundation/command-stream for all CLI and TUI operations

1 participant