Audit native process execution for command-stream#1865
Open
konard wants to merge 4 commits into
Open
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #1864
konard
marked this pull request as ready for review
June 8, 2026 11:53
Contributor
Author
Working session summaryImplemented and pushed the fix on PR #1865 is ready for review: #1865 Key changes:
Verification:
Working tree is clean. This summary was automatically extracted from the AI working session output. |
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (823.8K + 13.2M cached) input tokens, 57.2K output tokens, $24.000829 cost 🤖 Models used:
📎 Log file uploaded as Repository (70010KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Contributor
Author
✅ Ready to mergeThis pull request is now ready to be merged:
Monitored by hive-mind with --auto-restart-until-mergeable flag |
This reverts commit 809d40f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/command-stream-exec.lib.mjs, a command-stream-backed adapter for legacyexeccall sites that need{ stdout, stderr }and nonzero-exit errors.child_processusage must either migrate to command-stream or carry a documented exception.Case study: https://github.com/link-assistant/hive-mind/blob/issue-1864-58f21a62b46d/docs/case-studies/issue-1864/README.md
Reproduction and verification
node tests/test-issue-1864-command-stream-audit.mjsnode tests/test-command-stream-exec-wrapper-1864.mjsnode tests/github-rate-limit.test.mjsnode tests/test-execgh-transient-retry-1756.mjsnpm test > ci-logs/local-npm-test.log 2>&1- passed all 231 selected default test filesnpm run lint > ci-logs/local-npm-lint.log 2>&1- passednpm run format:check > ci-logs/local-npm-format-check.log 2>&1- passedUpstream command-stream notes
Existing upstream command-stream issues cover the blockers that kept 20 native-process exceptions, including process lifecycle/kill access, signal support, spawn/execFile-style argv execution, sync execution, and known quoting/output issues. No duplicate upstream issue was filed.
Fixes #1864